src/x64/full-codegen-x64.cc - Issue 18712002: Convert UnaryOpStub to a HydrogenCodeStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 18712002: Convert UnaryOpStub to a HydrogenCodeStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix builtin leakage Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index f2d98eb052893a09b2e9eaea4f25af6c5a01bb1d..a97279616d21454dbccaa521a272934beaf947d7 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -4356,10 +4356,7 @@ void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr,

const char* comment) {

// TODO(svenpanne): Allowing format strings in Comment would be nice here...

Comment cmt(masm_, comment);

- bool can_overwrite = expr->expression()->ResultOverwriteAllowed();

- UnaryOverwriteMode overwrite =

- can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE;

- UnaryOpStub stub(expr->op(), overwrite);

+ UnaryOpStub stub(expr->op());

// UnaryOpStub expects the argument to be in the

// accumulator register rax.

VisitForAccumulatorValue(expr->expression());