Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 18712002: Convert UnaryOpStub to a HydrogenCodeStub (Closed)

Created:
7 years, 5 months ago by oliv
Modified:
7 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Convert UnaryOpStub to a HydrogenCodeStub BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15506

Patch Set 1 : original cl #

Patch Set 2 : fix builtin leakage #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -1336 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +0 lines, -65 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 2 chunks +12 lines, -271 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M src/arm/lithium-arm.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 2 chunks +21 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 2 11 chunks +83 lines, -13 lines 0 comments Download
M src/code-stubs.cc View 1 2 7 chunks +114 lines, -32 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 11 chunks +68 lines, -55 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 chunks +45 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +0 lines, -74 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 2 chunks +11 lines, -319 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 chunks +31 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 4 chunks +27 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 2 chunks +23 lines, -1 line 0 comments Download
M src/ic.h View 3 chunks +3 lines, -22 lines 0 comments Download
M src/ic.cc View 1 2 4 chunks +15 lines, -130 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/property-details.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M src/types.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +0 lines, -71 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 2 chunks +12 lines, -254 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 2 chunks +21 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oliv
now including the pass-test262 feature :)
7 years, 5 months ago (2013-07-05 08:13:42 UTC) #1
danno
https://codereview.chromium.org/18712002/diff/18001/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/18712002/diff/18001/src/code-stubs-hydrogen.cc#newcode781 src/code-stubs-hydrogen.cc:781: AddInstruction(new(zone()) HPushArgument(GetParameter(0))); Add<HPushArgument>(GetParameter(0)); https://codereview.chromium.org/18712002/diff/18001/src/code-stubs-hydrogen.cc#newcode782 src/code-stubs-hydrogen.cc:782: if_number.Return(AddInstruction(new(zone()) HInvokeFunction( HValue* result ...
7 years, 5 months ago (2013-07-05 08:25:48 UTC) #2
oliv
PTAL had to rebase, since my branch point was before Add<>. I love the new ...
7 years, 5 months ago (2013-07-05 09:17:34 UTC) #3
danno
lgtm
7 years, 5 months ago (2013-07-05 09:19:47 UTC) #4
oliv
7 years, 5 months ago (2013-07-05 09:26:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r15506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698