Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 18712: Attempt to fix a IAT unpatch crash. (Closed)

Created:
11 years, 11 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
jam, ananta
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Attempt to fix a IAT unpatch crash. The IAT destructor (which will unpatch) now should run at AtExitManager shutdown, which is before we return from main(). It was a static constructor (bad), which registers an atexit() destructor which happens sometime during ExitProcess / LdrShutdown. Also this removes some static constructors (the iat patchers, the throttle_queue, etc). I removed a StatsCounter completely, removing its static initializer. BUG=6886

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M webkit/glue/plugins/webplugin_delegate_impl.h View 5 chunks +0 lines, -12 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.cc View 18 chunks +58 lines, -46 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
This code is kinda a mess. Sorry about killing the StatsCounter, but I didn't feel ...
11 years, 11 months ago (2009-01-23 15:09:16 UTC) #1
jam
11 years, 11 months ago (2009-01-23 19:26:22 UTC) #2
lgtm

For the windowless throttling, I'm not really sure if we need that code anymore
because of semi-recent performance improvements.  But I'll look at it later.

http://codereview.chromium.org/18712/diff/1/2
File webkit/glue/plugins/webplugin_delegate_impl.cc (right):

http://codereview.chromium.org/18712/diff/1/2#newcode575
Line 575: 
nit: no need for extra line?

Powered by Google App Engine
This is Rietveld 408576698