Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1871133002: [MD] Use strong call to action styling on solitary infobar buttons. (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Use strong call to action styling on solitary infobar buttons. BUG=596238 Committed: https://crrev.com/81cd5c907f341cbfe18e22c12a1315d6266fbf53 Cr-Commit-Position: refs/heads/master@{#386873}

Patch Set 1 #

Patch Set 2 : strong and independent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 1 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Evan Stade
A detail of the spec I previously failed to notice.
4 years, 8 months ago (2016-04-08 19:31:53 UTC) #2
Evan Stade
Latest patch changes the behavior. See comment #9 on bug.
4 years, 8 months ago (2016-04-08 20:48:21 UTC) #4
Peter Kasting
LGTM
4 years, 8 months ago (2016-04-12 22:41:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871133002/20001
4 years, 8 months ago (2016-04-12 22:53:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 00:15:45 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 00:17:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81cd5c907f341cbfe18e22c12a1315d6266fbf53
Cr-Commit-Position: refs/heads/master@{#386873}

Powered by Google App Engine
This is Rietveld 408576698