Stop choosing $TMPDIR as a safe place to create hardlinks on OSX.

Stop choosing $TMPDIR as a safe place to create hardlinks on OSX.

- Hardlinking doesn't update the inode modification time.
- /System/Library/LaunchDaemons/com.apple.bsd.dirhelper.plist runs every day at
  3:35am and deletes any file in $TMPDIR that is older than 3 days old.
- This means any isolated task mapped in $TMPDIR using files in the cache older
  than 3 days will get deleted my dirhelper if the task is running at 3:35am.
- Frustration while trying to diagnose this race condition ensue.

R=vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/luci-py/commit/90eecffb024b23387686702006cc4f1fa3f957a5

[M-A Ruel, 2016-04-08 19:08:15]

Description was changed from

==========
Stop choosing $TMPDIR as a safe place to create hardlinks on OSX.

- Hardlinking doesn't update the inode modification time.
- /System/Library/LaunchDaemons/com.apple.bsd.dirhelper.plist runs every day at
  3:35am and deletes any file in $TMPDIR that is older than 3 days old.
- This means any isolated task mapped in $TMPDIR using files in the cache older
  than 3 days will get deleted my dirhelper if the task is running at 3:35am.
- Frustration while trying to diagnose this race conditon ensue.

R=vadimsh@chromium.org
BUG=
==========

to

==========
Stop choosing $TMPDIR as a safe place to create hardlinks on OSX.

- Hardlinking doesn't update the inode modification time.
- /System/Library/LaunchDaemons/com.apple.bsd.dirhelper.plist runs every day at
  3:35am and deletes any file in $TMPDIR that is older than 3 days old.
- This means any isolated task mapped in $TMPDIR using files in the cache older
  than 3 days will get deleted my dirhelper if the task is running at 3:35am.
- Frustration while trying to diagnose this race condition ensue.

R=vadimsh@chromium.org
BUG=
==========

[Vadim Sh., 2016-04-08 19:11:53]

oh

lgtm

[M-A Ruel, 2016-04-08 20:35:00]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2016-04-08 20:35:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871113002/1

[M-A Ruel, 2016-04-08 20:37:43]

The CQ bit was unchecked by maruel@chromium.org

[M-A Ruel, 2016-04-08 20:38:08]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2016-04-08 20:38:08]

The CQ bit was unchecked by maruel@chromium.org

[M-A Ruel, 2016-04-08 20:38:09]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2016-04-08 20:38:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871113002/1

[commit-bot: I haz the power, 2016-04-08 20:39:59]

Description was changed from

==========
Stop choosing $TMPDIR as a safe place to create hardlinks on OSX.

- Hardlinking doesn't update the inode modification time.
- /System/Library/LaunchDaemons/com.apple.bsd.dirhelper.plist runs every day at
  3:35am and deletes any file in $TMPDIR that is older than 3 days old.
- This means any isolated task mapped in $TMPDIR using files in the cache older
  than 3 days will get deleted my dirhelper if the task is running at 3:35am.
- Frustration while trying to diagnose this race condition ensue.

R=vadimsh@chromium.org
BUG=
==========

to

==========
Stop choosing $TMPDIR as a safe place to create hardlinks on OSX.

- Hardlinking doesn't update the inode modification time.
- /System/Library/LaunchDaemons/com.apple.bsd.dirhelper.plist runs every day at
  3:35am and deletes any file in $TMPDIR that is older than 3 days old.
- This means any isolated task mapped in $TMPDIR using files in the cache older
  than 3 days will get deleted my dirhelper if the task is running at 3:35am.
- Frustration while trying to diagnose this race condition ensue.

R=vadimsh@chromium.org
BUG=

Committed:
https://github.com/luci/luci-py/commit/90eecffb024b23387686702006cc4f1fa3f957a5
==========

[commit-bot: I haz the power, 2016-04-08 20:40:00]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/90eecffb024b23387686702006cc4f1fa3f957a5

[Michael Achenbach, 2016-04-11 07:03:05]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-04-11 07:03:06]

Thanks for the fix! Lets hope that was the root cause...