Support for @JS() validation (#26225).

Support for @JS() validation (#26225).

See: https://github.com/dart-lang/sdk/issues/26225

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac48484a07ef3a8ad0109f4dfccfea2ce33267e0

[pquitslund, 2016-04-08 18:54:08]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[pquitslund, 2016-04-08 18:54:53]

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:4213: if
(element?.library?.isJS != true) {
Probably too careful...  Advise?

[Brian Wilkerson, 2016-04-08 19:15:31]

lgtm

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:4213: if
(element?.library?.isJS != true) {
Probably, but it's fine for now.

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/hint_code_test.dart (right):

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/hint_code_test.dart:1265: void test_missing_js_lib()
{
Maybe also test it on a class member (if that's allowed).

[terry, 2016-04-08 19:38:56]

terry@google.com changed reviewers:
+ terry@google.com

[terry, 2016-04-08 19:38:57]

Minor suggestion on test cases (top-level func is very common)

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/hint_code_test.dart (right):

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/hint_code_test.dart:1278: 
May want to test top-level function use of @JS

@JS('acxZIndex')
external int set _currentZIndex(int value);

[pquitslund, 2016-04-08 20:29:42]

Thanks!

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:4213: if
(element?.library?.isJS != true) {
On 2016/04/08 19:15:31, Brian Wilkerson wrote:
> Probably, but it's fine for now.

Acknowledged.

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/hint_code_test.dart (right):

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/hint_code_test.dart:1265: void test_missing_js_lib()
{
On 2016/04/08 19:15:31, Brian Wilkerson wrote:
> Maybe also test it on a class member (if that's allowed).

Done.

https://codereview.chromium.org/1871103002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/hint_code_test.dart:1278: 
On 2016/04/08 19:38:57, terry wrote:
> May want to test top-level function use of @JS
> 
> @JS('acxZIndex')
> external int set _currentZIndex(int value);

Done.

[pquitslund, 2016-04-08 20:45:13]

Description was changed from

==========
Support for @JS() validation (#26225).

See: https://github.com/dart-lang/sdk/issues/26225

BUG=
==========

to

==========
Support for @JS() validation (#26225).

See: https://github.com/dart-lang/sdk/issues/26225

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ac48484a07ef3a8ad0109f4dfccfea2ce33267e0
==========

[pquitslund, 2016-04-08 20:45:14]

Committed patchset #2 (id:20001) manually as
ac48484a07ef3a8ad0109f4dfccfea2ce33267e0 (presubmit successful).