Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1871093002: ipc: Add channel names to sync tests. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Add channel names to sync tests. This prevents flaky test failures on Windows. BUG=600775 Committed: https://crrev.com/99fbfc66cfb1bc58f5336303176fb341cc2c6aa7 Cr-Commit-Position: refs/heads/master@{#386231}

Patch Set 1 #

Patch Set 2 : Explicit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -66 lines) Patch
M ipc/ipc_sync_channel_unittest.cc View 1 26 chunks +84 lines, -66 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871093002/20001
4 years, 8 months ago (2016-04-08 18:51:01 UTC) #2
erikchen
tsepez: Please review.
4 years, 8 months ago (2016-04-08 19:28:03 UTC) #4
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-08 19:32:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 19:49:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871093002/20001
4 years, 8 months ago (2016-04-08 22:32:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 22:38:04 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 22:39:46 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/99fbfc66cfb1bc58f5336303176fb341cc2c6aa7
Cr-Commit-Position: refs/heads/master@{#386231}

Powered by Google App Engine
This is Rietveld 408576698