Fix for issue 22357: use type information on the RHS of is expressions to improve quality of comple…

Fix for issue 22357: use type information on the RHS of is expressions to improve quality of completions.

BUG=https://github.com/dart-lang/sdk/issues/22357
R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/bb62c408bf23ca2a54038ef9c554097a56eda586

[jwren, 2016-04-08 21:10:25]

jwren@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2016-04-08 22:07:52]

Nice work! LGTM once comments are addressed.

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
(right):

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:162:
AstNode node = request.target.containingNode;
I believe that this contains the expression that you need to resolve...

if (node is Expression) {
   await request.resolveExpression(node);
}

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:179:
}
I believe that my comment above will provide the resolution you need for "(foo
is ^)" and that this code can be removed.

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:184:
await request.resolveUnits();
This seems expensive to bake into the contributor. It forces everything to be
resolved. Please remove.

[jwren, 2016-04-08 22:16:34]

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
(right):

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:162:
AstNode node = request.target.containingNode;
On 2016/04/08 22:07:51, danrubel wrote:
> I believe that this contains the expression that you need to resolve...
> 
> if (node is Expression) {
>    await request.resolveExpression(node);
> }

Done.

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:179:
}
On 2016/04/08 22:07:51, danrubel wrote:
> I believe that my comment above will provide the resolution you need for "(foo
> is ^)" and that this code can be removed.

Done.

https://codereview.chromium.org/1871073003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:184:
await request.resolveUnits();
On 2016/04/08 22:07:52, danrubel wrote:
> This seems expensive to bake into the contributor. It forces everything to be
> resolved. Please remove.

Done.

[jwren, 2016-04-08 22:16:57]

Description was changed from

==========
Fix for issue 22357: use type information on the RHS of is expressions to
improve quality of completions.

BUG=https://github.com/dart-lang/sdk/issues/22357
==========

to

==========
Fix for issue 22357: use type information on the RHS of is expressions to
improve quality of completions.

BUG=https://github.com/dart-lang/sdk/issues/22357
R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bb62c408bf23ca2a54038ef9c554097a56eda586
==========

[jwren, 2016-04-08 22:16:58]

Committed patchset #2 (id:20001) manually as
bb62c408bf23ca2a54038ef9c554097a56eda586 (presubmit successful).