Only hit-test SVG <text> foreground

Only hit-test SVG <text> foreground

<text> doesn't have/paint any background, so performing hit-tests for
the various background is a both a waste of time, and gives rise to bugs
in some cases where poor precision renders false positives.
This also matches what LayoutSVGShape does (and <text> is a "graphics
element" just like the basic shapes.)
Rework the 'pointer-events: bounding-box' check to not rely on
nodeAtPoint. It's now somewhat consistent with how containers (<g>) are
handled.
This also affects how hit-testing works w/ 'textLength' ("artificial"
spaces will no longer be considered part of the <text> - this matches
the Firefox behavior.) Adjust svg/animations/svgenum-animation-3.html
to cater to this change in behavior.

BUG=601036
Committed: https://crrev.com/d44cc5eb0dd3240a5feef91f4ec09b5ae1ac5e5c
Cr-Commit-Position: refs/heads/master@{#386308}

[fs, 2016-04-08 12:27:40]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2016-04-08 12:48:29]

Description was changed from

==========
Only hit-text SVG <text> foreground

<text> doesn't have/paint any background, so performing hit-tests for
the various background is a both a waste of time, and gives rise to bugs
in some cases where poor precision renders false positives.
This also matches what LayoutSVGShape does (and <text> is a "graphics
element" just like the basic shapes.)
Rework the 'pointer-events: bounding-box' check to not rely on
nodeAtPoint. It's now somewhat consistent with how containers (<g>) are
handled.
This also affects how hit-testing works w/ 'textLength' ("artificial"
spaces will no longer be considered part of the <text> - this matches
the Firefox behavior.) Adjust svg/animations/svgenum-animation-3.html
to cater to this change in behavior.

BUG=601036
==========

to

==========
Only hit-test SVG <text> foreground

<text> doesn't have/paint any background, so performing hit-tests for
the various background is a both a waste of time, and gives rise to bugs
in some cases where poor precision renders false positives.
This also matches what LayoutSVGShape does (and <text> is a "graphics
element" just like the basic shapes.)
Rework the 'pointer-events: bounding-box' check to not rely on
nodeAtPoint. It's now somewhat consistent with how containers (<g>) are
handled.
This also affects how hit-testing works w/ 'textLength' ("artificial"
spaces will no longer be considered part of the <text> - this matches
the Firefox behavior.) Adjust svg/animations/svgenum-animation-3.html
to cater to this change in behavior.

BUG=601036
==========

[pdr., 2016-04-08 21:36:29]

LGTM

https://codereview.chromium.org/1870983002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/animations/script-tests/svgenum-animation-3.js
(right):

https://codereview.chromium.org/1870983002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/animations/script-tests/svgenum-animation-3.js:4:
var clickX = 1;
It looks like this is for SVGAnimationTestCase.js? If so, can you switch it to
"window.clickX = 1;" and add a comment about what it's for?

[fs, 2016-04-09 19:32:29]

https://codereview.chromium.org/1870983002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/animations/script-tests/svgenum-animation-3.js
(right):

https://codereview.chromium.org/1870983002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/animations/script-tests/svgenum-animation-3.js:4:
var clickX = 1;
On 2016/04/08 at 21:36:29, pdr wrote:
> It looks like this is for SVGAnimationTestCase.js? If so, can you switch it to
"window.clickX = 1;" and add a comment about what it's for?

Done.

[pdr., 2016-04-09 20:12:28]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-04-09 20:12:28]

lgtm

[commit-bot: I haz the power, 2016-04-09 20:12:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870983002/40001

[commit-bot: I haz the power, 2016-04-09 20:40:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-09 20:41:40]

Description was changed from

==========
Only hit-test SVG <text> foreground

<text> doesn't have/paint any background, so performing hit-tests for
the various background is a both a waste of time, and gives rise to bugs
in some cases where poor precision renders false positives.
This also matches what LayoutSVGShape does (and <text> is a "graphics
element" just like the basic shapes.)
Rework the 'pointer-events: bounding-box' check to not rely on
nodeAtPoint. It's now somewhat consistent with how containers (<g>) are
handled.
This also affects how hit-testing works w/ 'textLength' ("artificial"
spaces will no longer be considered part of the <text> - this matches
the Firefox behavior.) Adjust svg/animations/svgenum-animation-3.html
to cater to this change in behavior.

BUG=601036
==========

to

==========
Only hit-test SVG <text> foreground

<text> doesn't have/paint any background, so performing hit-tests for
the various background is a both a waste of time, and gives rise to bugs
in some cases where poor precision renders false positives.
This also matches what LayoutSVGShape does (and <text> is a "graphics
element" just like the basic shapes.)
Rework the 'pointer-events: bounding-box' check to not rely on
nodeAtPoint. It's now somewhat consistent with how containers (<g>) are
handled.
This also affects how hit-testing works w/ 'textLength' ("artificial"
spaces will no longer be considered part of the <text> - this matches
the Firefox behavior.) Adjust svg/animations/svgenum-animation-3.html
to cater to this change in behavior.

BUG=601036

Committed: https://crrev.com/d44cc5eb0dd3240a5feef91f4ec09b5ae1ac5e5c
Cr-Commit-Position: refs/heads/master@{#386308}
==========

[commit-bot: I haz the power, 2016-04-09 20:41:42]

Patchset 3 (id:??) landed as
https://crrev.com/d44cc5eb0dd3240a5feef91f4ec09b5ae1ac5e5c
Cr-Commit-Position: refs/heads/master@{#386308}