Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1870943002: Revert "Ship the Credential Management API by default" from M50. (Closed)

Created:
4 years, 8 months ago by Mike West
Modified:
4 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, creis+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, gcasto+watchlist_chromium.org, kinuko+watch, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Revert "Ship the Credential Management API by default" from M50. This reverts commit 062c94e083bb1a2ec9df0222cdbdff6b364cb466, which should have landed only after the M50 branch point. > Ship the Credential Management API by default > > This patch enables the Credential Management API by default. > > It also converts the existing CLI flag into a `base::Feature`, which will allow > us to hook it up to Finch as a kill-switch in case it asplodes the internets. > This feature flag can be removed after ~a release, once we're confident that > we're not breaking things. > > Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0 > > BUG=576705 > R=vabr@chromium.org > > Committed: https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466 > Cr-Commit-Position: refs/heads/master@{#377276} BUG=601130 TBR=vabr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -46 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 4 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 8 months ago (2016-04-08 07:18:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2176c7a2a03c5dbd4f98f3fd90c2a4f9dd20948.

Powered by Google App Engine
This is Rietveld 408576698