Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 187093002: Fix error in barelinux_make build script (Closed)

Created:
6 years, 9 months ago by hal.canary
Modified:
6 years, 9 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix error in barelinux_make build script Committed: http://code.google.com/p/skia/source/detail?r=13661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
platform_tools/barelinux/bin/barelinux_make View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hal.canary
I uncovered this bug in my own code while testing the buildbot code. Please take ...
6 years, 9 months ago (2014-03-04 22:09:57 UTC) #1
borenet
LGTM
6 years, 9 months ago (2014-03-04 22:13:54 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-04 22:16:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/187093002/1
6 years, 9 months ago (2014-03-04 22:16:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 22:31:18 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-04 22:31:19 UTC) #6
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-04 22:32:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/187093002/1
6 years, 9 months ago (2014-03-04 22:32:23 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 22:32:56 UTC) #9
Message was sent while issue was closed.
Change committed as 13661

Powered by Google App Engine
This is Rietveld 408576698