Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1870903002: recipe_roll_tryjob: Add service_account argument. (Closed)

Created:
4 years, 8 months ago by martiniss
Modified:
4 years, 8 months ago
Reviewers:
estaab
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

recipe_roll_tryjob: Add service_account argument. R=estaab BUG=591172 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299787

Patch Set 1 #

Patch Set 2 : pragma no cover #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M scripts/slave/recipes/infra/recipe_roll_tryjob.py View 1 2 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
martiniss
PTAL
4 years, 8 months ago (2016-04-08 01:01:28 UTC) #2
estaab
lgtm
4 years, 8 months ago (2016-04-08 02:17:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870903002/1
4 years, 8 months ago (2016-04-08 02:30:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3717)
4 years, 8 months ago (2016-04-08 02:38:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870903002/20001
4 years, 8 months ago (2016-04-08 02:52:31 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 02:56:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299787

Powered by Google App Engine
This is Rietveld 408576698