Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 18709003: Delete deprecated CPU profiler code that supports filtering by security token (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Delete deprecated CPU profiler code that supports filtering by security token The methods that allow to filter CPU profile by security token were introduced to support console.profiles in WebKit. Now that console.profiles is removed and corresponding V8 API methods have been deprecated in 3.19 branch(https://code.google.com/p/v8/source/browse/branches/3.19/include/v8-profiler.h) it is safe to remove all that code. BUG=None R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15528

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase 2 #

Total comments: 4

Patch Set 4 : Format code as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -587 lines) Patch
M include/v8-profiler.h View 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/api.cc View 2 3 chunks +2 lines, -30 lines 0 comments Download
M src/cpu-profiler.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/cpu-profiler.cc View 13 chunks +7 lines, -32 lines 0 comments Download
M src/heap-snapshot-generator.h View 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/profile-generator.h View 9 chunks +3 lines, -49 lines 0 comments Download
M src/profile-generator.cc View 10 chunks +14 lines, -241 lines 0 comments Download
M src/profile-generator-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 3 4 chunks +2 lines, -62 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 7 chunks +5 lines, -146 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 5 months ago (2013-07-04 16:37:12 UTC) #1
loislo
lgtm https://codereview.chromium.org/18709003/diff/14001/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/18709003/diff/14001/test/cctest/test-cpu-profiler.cc#newcode226 test/cctest/test-cpu-profiler.cc:226: profiles->StopProfiling("", 1); single line https://codereview.chromium.org/18709003/diff/14001/test/cctest/test-cpu-profiler.cc#newcode291 test/cctest/test-cpu-profiler.cc:291: profiles->StopProfiling("", 1); ...
7 years, 5 months ago (2013-07-04 16:49:54 UTC) #2
yurys
https://codereview.chromium.org/18709003/diff/14001/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/18709003/diff/14001/test/cctest/test-cpu-profiler.cc#newcode226 test/cctest/test-cpu-profiler.cc:226: profiles->StopProfiling("", 1); On 2013/07/04 16:49:54, loislo wrote: > single ...
7 years, 5 months ago (2013-07-04 16:57:58 UTC) #3
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-06 07:55:02 UTC) #4
yurys
7 years, 5 months ago (2013-07-06 09:12:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r15528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698