Destroy the CDM asynchronously

Destroy the CDM asynchronously

CDM destruction can potentially take a long time, so do this
asynchronously.

When the CDM is destroyed, any unfulfilled promises are rejected.
If this happens during blink garbage collection (nothing refers to the
EME blink objects anymore), blink doesn't like creating new objects
(rejection results in a DOMException being created). So post a task
to delete the CDM asynchronously, which will reject the unfulfilled
promises later (after gc is done).

BUG=597355
TEST=existing EME tests still pass

Committed: https://crrev.com/23f24a3c67f11e066f65820298c73d438f88da29
Cr-Commit-Position: refs/heads/master@{#386130}

[jrummell, 2016-04-08 01:16:10]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, halliwell@chromium.org, xhwang@chromium.org

[jrummell, 2016-04-08 01:16:10]

PTAL. Third attempt at fixing the cast shutdown crash.

[halliwell, 2016-04-08 15:20:07]

On 2016/04/08 01:16:10, jrummell wrote:
> PTAL. Third attempt at fixing the cast shutdown crash.

lgtm, ran our test case on loop for 2 hours now without a crash.

[ddorwin, 2016-04-08 17:06:26]

You might include the part about CDM destruction potentially taking a long time
to the description. I believe that is why we settled on this solution, which
happens to fix the promises issue.

LGTM

[jrummell, 2016-04-08 17:53:11]

Description was changed from

==========
Destroy the CDM asynchronously

When the CDM is destroyed, any unfulfilled promises are rejected.
If this happens during blink garbage collection (nothing refers to the
EME blink objects anymore), blink doesn't like creating new objects
(rejection results in a DOMException being created). So post a task
to delete the CDM asynchronously, which will reject the unfulfilled
promises later (after gc is done).

BUG=597355
TEST=existing EME tests still pass
==========

to

==========
Destroy the CDM asynchronously

CDM destruction can potentially take a long time, so do this
asynchronously.

When the CDM is destroyed, any unfulfilled promises are rejected.
If this happens during blink garbage collection (nothing refers to the
EME blink objects anymore), blink doesn't like creating new objects
(rejection results in a DOMException being created). So post a task
to delete the CDM asynchronously, which will reject the unfulfilled
promises later (after gc is done).

BUG=597355
TEST=existing EME tests still pass
==========

[jrummell, 2016-04-08 17:53:39]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2016-04-08 17:53:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870883003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870883003/1

[commit-bot: I haz the power, 2016-04-08 18:34:22]

Description was changed from

==========
Destroy the CDM asynchronously

CDM destruction can potentially take a long time, so do this
asynchronously.

When the CDM is destroyed, any unfulfilled promises are rejected.
If this happens during blink garbage collection (nothing refers to the
EME blink objects anymore), blink doesn't like creating new objects
(rejection results in a DOMException being created). So post a task
to delete the CDM asynchronously, which will reject the unfulfilled
promises later (after gc is done).

BUG=597355
TEST=existing EME tests still pass
==========

to

==========
Destroy the CDM asynchronously

CDM destruction can potentially take a long time, so do this
asynchronously.

When the CDM is destroyed, any unfulfilled promises are rejected.
If this happens during blink garbage collection (nothing refers to the
EME blink objects anymore), blink doesn't like creating new objects
(rejection results in a DOMException being created). So post a task
to delete the CDM asynchronously, which will reject the unfulfilled
promises later (after gc is done).

BUG=597355
TEST=existing EME tests still pass
==========

[commit-bot: I haz the power, 2016-04-08 18:34:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 18:36:56]

Description was changed from

==========
Destroy the CDM asynchronously

CDM destruction can potentially take a long time, so do this
asynchronously.

When the CDM is destroyed, any unfulfilled promises are rejected.
If this happens during blink garbage collection (nothing refers to the
EME blink objects anymore), blink doesn't like creating new objects
(rejection results in a DOMException being created). So post a task
to delete the CDM asynchronously, which will reject the unfulfilled
promises later (after gc is done).

BUG=597355
TEST=existing EME tests still pass
==========

to

==========
Destroy the CDM asynchronously

CDM destruction can potentially take a long time, so do this
asynchronously.

When the CDM is destroyed, any unfulfilled promises are rejected.
If this happens during blink garbage collection (nothing refers to the
EME blink objects anymore), blink doesn't like creating new objects
(rejection results in a DOMException being created). So post a task
to delete the CDM asynchronously, which will reject the unfulfilled
promises later (after gc is done).

BUG=597355
TEST=existing EME tests still pass

Committed: https://crrev.com/23f24a3c67f11e066f65820298c73d438f88da29
Cr-Commit-Position: refs/heads/master@{#386130}
==========

[commit-bot: I haz the power, 2016-04-08 18:36:57]

Patchset 1 (id:??) landed as
https://crrev.com/23f24a3c67f11e066f65820298c73d438f88da29
Cr-Commit-Position: refs/heads/master@{#386130}

[xhwang, 2016-04-11 16:52:20]

lgtm

https://codereview.chromium.org/1870883003/diff/1/media/blink/cdm_session_ada...
File media/blink/cdm_session_adapter.cc (right):

https://codereview.chromium.org/1870883003/diff/1/media/blink/cdm_session_ada...
media/blink/cdm_session_adapter.cc:46: FROM_HERE, base::Bind(&ReleaseCdm,
cdm_));
nit: This can be done with MessageLoop::ReleaseSoon:

https://code.google.com/p/chromium/codesearch#chromium/src/base/message_loop/...

Though I don't really like the syntax using it (AddRef, take raw pointer etc).