Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 1870853003: Vulcanize settings (hacky and dirty, don't use) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git squash commit. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-menu' shows a menu with a hardcoded set of pages and subpages. 7 * 'settings-menu' shows a menu with a hardcoded set of pages and subpages.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-menu', 10 is: 'settings-menu',
(...skipping 22 matching lines...) Expand all
33 }.bind(this)); 33 }.bind(this));
34 34
35 this.$.advancedPage.addEventListener('paper-submenu-open', function() { 35 this.$.advancedPage.addEventListener('paper-submenu-open', function() {
36 this.fire('toggle-advanced-page', true); 36 this.fire('toggle-advanced-page', true);
37 }.bind(this)); 37 }.bind(this));
38 38
39 this.$.advancedPage.addEventListener('paper-submenu-close', function() { 39 this.$.advancedPage.addEventListener('paper-submenu-close', function() {
40 this.fire('toggle-advanced-page', false); 40 this.fire('toggle-advanced-page', false);
41 }.bind(this)); 41 }.bind(this));
42 42
43 this.fire('toggle-advanced-page', this.currentRoute.page == 'advanced'); 43 // TODO(michaelpg): Why is this.currentRoute undefined when vulcanized?
44 this.fire('toggle-advanced-page',
45 this.currentRoute && this.currentRoute.page == 'advanced');
44 }, 46 },
45 47
46 /** 48 /**
47 * @param {!SettingsRoute} newRoute 49 * @param {!SettingsRoute} newRoute
48 * @private 50 * @private
49 */ 51 */
50 currentRouteChanged_: function(newRoute) { 52 currentRouteChanged_: function(newRoute) {
51 // Sync URL changes to the side nav menu. 53 // Sync URL changes to the side nav menu.
52 54
53 if (newRoute.page == 'advanced') { 55 if (newRoute.page == 'advanced') {
(...skipping 25 matching lines...) Expand all
79 81
80 /** 82 /**
81 * @param {boolean} opened Whether the menu is expanded. 83 * @param {boolean} opened Whether the menu is expanded.
82 * @return {string} Which icon to use. 84 * @return {string} Which icon to use.
83 * @private 85 * @private
84 * */ 86 * */
85 arrowState_: function(opened) { 87 arrowState_: function(opened) {
86 return opened ? 'settings:arrow-drop-up' : 'cr:arrow-drop-down'; 88 return opened ? 'settings:arrow-drop-up' : 'cr:arrow-drop-down';
87 }, 89 },
88 }); 90 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698