Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 1870833005: relnote: Implements OnHeaderFrameStart and OnHeaderFrameEnd in QuicHeadersStream. Not used in produ… (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, birenroy
Base URL:
https://chromium.googlesource.com/chromium/src.git@06_CL_119188441
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Implements OnHeaderFrameStart and OnHeaderFrameEnd in QuicHeadersStream. Not used in production. Not protected. A new helper data structure, QuicHeaderList, is used to store an ordered list of header pairs for later interpretation. Instead of SPDY3-encoded header block bytes, a QuicHeaderList is passed through the various QUIC stream APIs. Merge internal change: 119198371 BUG=

Patch Set 1 #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -7 lines) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A net/quic/quic_header_list.h View 1 chunk +52 lines, -0 lines 2 comments Download
A net/quic/quic_header_list.cc View 1 chunk +38 lines, -0 lines 2 comments Download
A net/quic/quic_header_list_test.cc View 1 chunk +50 lines, -0 lines 2 comments Download
M net/quic/quic_headers_stream.h View 3 chunks +7 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 4 chunks +42 lines, -5 lines 2 comments Download
M net/quic/quic_spdy_session.h View 3 chunks +17 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_session.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream.h View 7 chunks +28 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 5 chunks +71 lines, -1 line 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 2 chunks +33 lines, -0 lines 0 comments Download
M net/quic/spdy_utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/spdy_utils.cc View 2 chunks +50 lines, -0 lines 3 comments Download
M net/spdy/spdy_headers_handler_interface.h View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
Zhongyi Shi
This CL will need a backports once landed in the final merge. 1. all implementation ...
4 years, 8 months ago (2016-04-08 19:52:00 UTC) #2
ramant (doing other things)
Please add blank lines in the new files, except that LGTM. https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.cc File net/quic/quic_header_list.cc (right): ...
4 years, 8 months ago (2016-04-11 18:11:58 UTC) #5
Zhongyi Shi
4 years, 8 months ago (2016-04-11 18:27:31 UTC) #6
All the nits are addressed in the Final CL, ptal.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.cc
File net/quic/quic_header_list.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.c...
net/quic/quic_header_list.cc:4: #include "net/quic/quic_header_list.h"
On 2016/04/11 18:11:57, ramant wrote:
> Please add a blank line between line#3 and line#4 (similar to other files).

done in the final.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.h
File net/quic/quic_header_list.h (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.h...
net/quic/quic_header_list.h:4: #ifndef NET_QUIC_QUIC_HEADER_LIST_H_
On 2016/04/11 18:11:57, ramant wrote:
> Please add a blank line between line#3 and line#4 (similar to other files).

Done in the Final CL.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list_t...
File net/quic/quic_header_list_test.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list_t...
net/quic/quic_header_list_test.cc:4: #include "net/quic/quic_header_list.h"
On 2016/04/11 18:11:57, ramant wrote:
> Please add a blank line between line#3 and line#4 (similar to other files).

done in the final.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_headers_strea...
File net/quic/quic_headers_stream.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_headers_strea...
net/quic/quic_headers_stream.cc:375: << ": Net.QuicSession.HeadersHOLBlockedTime
"
On 2016/04/11 18:11:57, ramant wrote:
> nit: indentation for lines 375-376.

it's already fixed in Final.

https://codereview.chromium.org/1870833005/diff/1/net/quic/spdy_utils.cc
File net/quic/spdy_utils.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/spdy_utils.cc#newc...
net/quic/spdy_utils.cc:127: << " contains upper-case characters.";
On 2016/04/11 18:11:57, ramant wrote:
> nit: indent line# 127

Already fixed in final.

Powered by Google App Engine
This is Rietveld 408576698