relnote: Implements OnHeaderFrameStart and OnHeaderFrameEnd in QuicHeadersStream. Not used in produ…

relnote: Implements OnHeaderFrameStart and OnHeaderFrameEnd in QuicHeadersStream. Not used in production. Not protected.

A new helper data structure, QuicHeaderList, is used to store an ordered
list of header pairs for later interpretation. Instead of SPDY3-encoded
header block bytes, a QuicHeaderList is passed through the various QUIC
stream APIs.

Merge internal change: 119198371

BUG=

[Zhongyi Shi, 2016-04-08 19:52:00]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2016-04-08 19:52:00]

This CL will need a backports once landed in the final merge. 

1. all implementation of QuicHeaderList methods should be moved from .h to .cc
file. 
2. QuicHeaderListTest: StrApp method is n/a on chromium, use append directly.
QuicHeaderListTest definition needs to be added.
3. TBD: spdy_utils.cc: asc_isupper is n/a in chromium. I defined this single
method rather than porting the whole file. Code is now inconsistent.

[Zhongyi Shi, 2016-04-11 17:39:23]

Description was changed from

==========
relnote: Implements OnHeaderFrameStart and OnHeaderFrameEnd in
QuicHeadersStream. Not used in production. Not protected.

A new helper data structure, QuicHeaderList, is used to store an ordered
list of header pairs for later interpretation. Instead of SPDY3-encoded
header block bytes, a QuicHeaderList is passed through the various QUIC
stream APIs.

Merge internal change: 119198371

BUG=
==========

to

==========
relnote: Implements OnHeaderFrameStart and OnHeaderFrameEnd in
QuicHeadersStream. Not used in production. Not protected.

A new helper data structure, QuicHeaderList, is used to store an ordered
list of header pairs for later interpretation. Instead of SPDY3-encoded
header block bytes, a QuicHeaderList is passed through the various QUIC
stream APIs.

Merge internal change: 119198371

BUG=
==========

[Zhongyi Shi, 2016-04-11 17:39:23]

zhongyi@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2016-04-11 18:11:58]

Please add blank lines in the new files, except that LGTM.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.cc
File net/quic/quic_header_list.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.c...
net/quic/quic_header_list.cc:4: #include "net/quic/quic_header_list.h"
Please add a blank line between line#3 and line#4 (similar to other files).

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.h
File net/quic/quic_header_list.h (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.h...
net/quic/quic_header_list.h:4: #ifndef NET_QUIC_QUIC_HEADER_LIST_H_
Please add a blank line between line#3 and line#4 (similar to other files).

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list_t...
File net/quic/quic_header_list_test.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list_t...
net/quic/quic_header_list_test.cc:4: #include "net/quic/quic_header_list.h"
Please add a blank line between line#3 and line#4 (similar to other files).

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_headers_strea...
File net/quic/quic_headers_stream.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_headers_strea...
net/quic/quic_headers_stream.cc:375: << ": Net.QuicSession.HeadersHOLBlockedTime
"
nit: indentation for lines 375-376.

https://codereview.chromium.org/1870833005/diff/1/net/quic/spdy_utils.cc
File net/quic/spdy_utils.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/spdy_utils.cc#newc...
net/quic/spdy_utils.cc:23: bool ascii_isupper(unsigned char c) {
nit: consider adding this to strings/string_util.h (ala IsAsciiAlpha) in a
separate CL?

https://codereview.chromium.org/1870833005/diff/1/net/quic/spdy_utils.cc#newc...
net/quic/spdy_utils.cc:127: << " contains upper-case characters.";
nit: indent line# 127

[Zhongyi Shi, 2016-04-11 18:27:31]

All the nits are addressed in the Final CL, ptal.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.cc
File net/quic/quic_header_list.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.c...
net/quic/quic_header_list.cc:4: #include "net/quic/quic_header_list.h"
On 2016/04/11 18:11:57, ramant wrote:
> Please add a blank line between line#3 and line#4 (similar to other files).

done in the final.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.h
File net/quic/quic_header_list.h (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list.h...
net/quic/quic_header_list.h:4: #ifndef NET_QUIC_QUIC_HEADER_LIST_H_
On 2016/04/11 18:11:57, ramant wrote:
> Please add a blank line between line#3 and line#4 (similar to other files).

Done in the Final CL.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list_t...
File net/quic/quic_header_list_test.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_header_list_t...
net/quic/quic_header_list_test.cc:4: #include "net/quic/quic_header_list.h"
On 2016/04/11 18:11:57, ramant wrote:
> Please add a blank line between line#3 and line#4 (similar to other files).

done in the final.

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_headers_strea...
File net/quic/quic_headers_stream.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/quic_headers_strea...
net/quic/quic_headers_stream.cc:375: << ": Net.QuicSession.HeadersHOLBlockedTime
"
On 2016/04/11 18:11:57, ramant wrote:
> nit: indentation for lines 375-376.

it's already fixed in Final.

https://codereview.chromium.org/1870833005/diff/1/net/quic/spdy_utils.cc
File net/quic/spdy_utils.cc (right):

https://codereview.chromium.org/1870833005/diff/1/net/quic/spdy_utils.cc#newc...
net/quic/spdy_utils.cc:127: << " contains upper-case characters.";
On 2016/04/11 18:11:57, ramant wrote:
> nit: indent line# 127

Already fixed in final.