chromeos: Add out-of-line copy ctors for complex classes.

chromeos: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=oshima@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/2a0c1040b8446eddb72064772aee97a5bac57e09
Cr-Commit-Position: refs/heads/master@{#386207}

[vmpstr, 2016-04-07 22:25:56]

Please take a look.

[dcheng, 2016-04-07 22:27:39]

rs lgtm

[oshima, 2016-04-07 22:37:00]

lgtm

[vmpstr, 2016-04-07 23:18:53]

vmpstr@chromium.org changed reviewers:
+ armansito@chromium.org

[vmpstr, 2016-04-07 23:18:53]

+armansito for chromeos/network

[vmpstr, 2016-04-08 20:27:21]

vmpstr@chromium.org changed reviewers:
+ cschuet@chromium.org

[vmpstr, 2016-04-08 20:27:22]

+cschuet as well for chromeos/network

[cschuet (SLOW), 2016-04-08 20:43:47]

On 2016/04/08 20:27:22, vmpstr wrote:
> +cschuet as well for chromeos/network

lgtm

[vmpstr, 2016-04-08 20:45:28]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-04-08 20:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870833003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870833003/1

[commit-bot: I haz the power, 2016-04-08 21:28:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 21:30:40]

Description was changed from

==========
chromeos: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=oshima@chromium.org, dcheng@chromium.org, thakis@chromium.org
==========

to

==========
chromeos: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=oshima@chromium.org, dcheng@chromium.org, thakis@chromium.org

Committed: https://crrev.com/2a0c1040b8446eddb72064772aee97a5bac57e09
Cr-Commit-Position: refs/heads/master@{#386207}
==========

[commit-bot: I haz the power, 2016-04-08 21:30:41]

Patchset 1 (id:??) landed as
https://crrev.com/2a0c1040b8446eddb72064772aee97a5bac57e09
Cr-Commit-Position: refs/heads/master@{#386207}