Change content view switching animation for experimental app launcher.

Change content view switching animation for experimental app launcher.

This CL implements a different animation for the experimental app list.
The change will allow more views to be added with a default animation
when switching the contents view.

BUG=349727
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255812

[tapted, 2014-03-05 07:37:17]

These need to have a tracker BUG=. Once that's added, lgm with nits.

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
File ui/app_list/views/contents_view.cc (right):

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.cc:114: int incoming_view = 0;
nit: incoming_view_index or incoming_index

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.cc:126: gfx::Rect
incoming_target(GetContentsBounds());
nit: initialise these both with |rect|?

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.cc:131: views::View* view =
view_model_->view_at(i);
|view| unused?

[tapted, 2014-03-06 03:33:03]

oops - lGtm

[calamity, 2014-03-07 00:30:51]

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
File ui/app_list/views/contents_view.cc (right):

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.cc:114: int incoming_view = 0;
On 2014/03/05 07:37:17, tapted wrote:
> nit: incoming_view_index or incoming_index

Done.

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.cc:126: gfx::Rect
incoming_target(GetContentsBounds());
On 2014/03/05 07:37:17, tapted wrote:
> nit: initialise these both with |rect|?

Done.

https://codereview.chromium.org/187083004/diff/1/ui/app_list/views/contents_v...
ui/app_list/views/contents_view.cc:131: views::View* view =
view_model_->view_at(i);
On 2014/03/05 07:37:17, tapted wrote:
> |view| unused?

Done.

[calamity, 2014-03-07 03:35:09]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-07 03:42:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/187083004/60001

[commit-bot: I haz the power, 2014-03-07 05:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 05:47:59]

Try jobs failed on following builders: mac_chromium_rel

[calamity, 2014-03-07 06:10:44]

The CQ bit was checked by calamity@chromium.org

[calamity, 2014-03-07 06:10:44]

The CQ bit was unchecked by calamity@chromium.org

[calamity, 2014-03-09 01:37:31]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-03-09 01:38:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/187083004/60001

[commit-bot: I haz the power, 2014-03-09 03:04:55]

Change committed as 255812