src/parser.cc - Issue 18708: Irregexp Issue 187: Captures in look-aheads are correctly cleared when backtracking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 18708: Irregexp Issue 187: Captures in look-aheads are correctly cleared when backtracking. (Closed)

Patch Set: Addressed review comments Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 9e7b4b311ecd6ab3888ea9e73dff68c350652759..6b9242996a4e46baebcf1f2b0a09867e345b5f05 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -4149,7 +4149,10 @@ RegExpTree* RegExpParser::ParseGroup() {

} else {

ASSERT(type == '=' || type == '!');

bool is_positive = (type == '=');

- return new RegExpLookahead(body, is_positive);

+ return new RegExpLookahead(body,

+ is_positive,

+ end_capture_index - capture_index,

+ capture_index);

}

« no previous file with comments | « src/jsregexp.cc ('k') | src/regexp-macro-assembler.h » ('j') | no next file with comments »