third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp - Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-filter-outsets-2

Patch Set: merge with master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

index 8d231ac7e9d38407adc519d7849482dcc1d91e0c..462d8524e5cc9f24493cd99ce91d9a81823ab59f 100644

--- a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

@@ -231,7 +231,7 @@ bool FilterEffectBuilder::build(Element* element, const FilterOperations& operat

}

case FilterOperation::BOX_REFLECT: {

BoxReflectFilterOperation* boxReflectOperation = toBoxReflectFilterOperation(filterOperation);

- effect = FEBoxReflect::create(parentFilter, boxReflectOperation->direction(), boxReflectOperation->offset());

+ effect = FEBoxReflect::create(parentFilter, boxReflectOperation->reflection());

break;

}

default:

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »