chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/open_file.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/operation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

index 8593a9aca04a88c39728663c957473bd5dd03952..d7fce02b30216b2184b98fe5c1f408bff2496c4d 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

@@ -4,13 +4,13 @@

#include "chrome/browser/chromeos/file_system_provider/operations/open_file.h"

+#include <memory>

#include <string>

#include <vector>

#include "base/files/file.h"

#include "base/files/file_path.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/scoped_vector.h"

#include "chrome/browser/chromeos/file_system_provider/operations/test_util.h"

#include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"

@@ -185,7 +185,7 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, OnSuccess) {

EXPECT_TRUE(open_file.Execute(kRequestId));

open_file.OnSuccess(kRequestId,

- scoped_ptr<RequestValue>(new RequestValue()),

+ std::unique_ptr<RequestValue>(new RequestValue()),

false /* has_more */);

ASSERT_EQ(1u, callback_logger.events().size());

CallbackLogger::Event* event = callback_logger.events()[0];

@@ -208,7 +208,7 @@ TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) {

EXPECT_TRUE(open_file.Execute(kRequestId));

open_file.OnError(kRequestId,

- scoped_ptr<RequestValue>(new RequestValue()),

+ std::unique_ptr<RequestValue>(new RequestValue()),

base::File::FILE_ERROR_TOO_MANY_OPENED);

ASSERT_EQ(1u, callback_logger.events().size());

CallbackLogger::Event* event = callback_logger.events()[0];