Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
diff --git a/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
index de73217682111f26cbaed33b36dd2eb4324d213f..656d8e5d434f2156f9b0997a5d33b0f32e078b76 100644
--- a/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
+++ b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
@@ -4,6 +4,8 @@
#include <stdint.h>
+
+#include <memory>
#include <string>
#include <utility>
#include <vector>
@@ -12,7 +14,7 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/string_util.h"
@@ -168,7 +170,7 @@ class CryptohomeAuthenticatorTest : public testing::Test {
fake_cryptohome_client_ = new FakeCryptohomeClient;
chromeos::DBusThreadManager::GetSetterForTesting()->SetCryptohomeClient(
- scoped_ptr<CryptohomeClient>(fake_cryptohome_client_));
+ std::unique_ptr<CryptohomeClient>(fake_cryptohome_client_));
SystemSaltGetter::Initialize();
@@ -247,8 +249,8 @@ class CryptohomeAuthenticatorTest : public testing::Test {
.RetiresOnSaturation();
}
- void ExpectGetKeyDataExCall(scoped_ptr<int64_t> key_type,
- scoped_ptr<std::string> salt) {
+ void ExpectGetKeyDataExCall(std::unique_ptr<int64_t> key_type,
+ std::unique_ptr<std::string> salt) {
key_definitions_.clear();
key_definitions_.push_back(cryptohome::KeyDefinition(
std::string() /* secret */,
@@ -325,7 +327,7 @@ class CryptohomeAuthenticatorTest : public testing::Test {
ScopedTestCrosSettings test_cros_settings_;
TestingProfile profile_;
- scoped_ptr<TestingProfileManager> profile_manager_;
+ std::unique_ptr<TestingProfileManager> profile_manager_;
user_manager::FakeUserManager* user_manager_;
ScopedUserManagerEnabler user_manager_enabler_;
@@ -335,7 +337,7 @@ class CryptohomeAuthenticatorTest : public testing::Test {
MockAuthStatusConsumer consumer_;
scoped_refptr<CryptohomeAuthenticator> auth_;
- scoped_ptr<TestAttemptState> state_;
+ std::unique_ptr<TestAttemptState> state_;
FakeCryptohomeClient* fake_cryptohome_client_;
scoped_refptr<ownership::MockOwnerKeyUtil> owner_key_util_;
@@ -570,7 +572,8 @@ TEST_F(CryptohomeAuthenticatorTest, DriveDataResync) {
// Set up mock homedir methods to respond successfully to a cryptohome create
// attempt.
- ExpectGetKeyDataExCall(scoped_ptr<int64_t>(), scoped_ptr<std::string>());
+ ExpectGetKeyDataExCall(std::unique_ptr<int64_t>(),
+ std::unique_ptr<std::string>());
ExpectMountExCall(true /* expect_create_attempt */);
state_->PresetOnlineLoginStatus(AuthFailure::AuthFailureNone());
@@ -627,7 +630,8 @@ TEST_F(CryptohomeAuthenticatorTest, DriveDataRecover) {
// Set up mock homedir methods to respond successfully to a cryptohome mount
// attempt.
- ExpectGetKeyDataExCall(scoped_ptr<int64_t>(), scoped_ptr<std::string>());
+ ExpectGetKeyDataExCall(std::unique_ptr<int64_t>(),
+ std::unique_ptr<std::string>());
ExpectMountExCall(false /* expect_create_attempt */);
state_->PresetOnlineLoginStatus(AuthFailure::AuthFailureNone());
@@ -690,7 +694,8 @@ TEST_F(CryptohomeAuthenticatorTest, DriveCreateForNewUser) {
// Set up mock homedir methods to respond successfully to a cryptohome create
// attempt.
- ExpectGetKeyDataExCall(scoped_ptr<int64_t>(), scoped_ptr<std::string>());
+ ExpectGetKeyDataExCall(std::unique_ptr<int64_t>(),
+ std::unique_ptr<std::string>());
ExpectMountExCall(true /* expect_create_attempt */);
// Set up state as though a cryptohome mount attempt has occurred
@@ -761,8 +766,8 @@ TEST_F(CryptohomeAuthenticatorTest, DriveLoginWithPreHashedPassword) {
// mount when this pre-hashed key is used.
ExpectGetKeyDataExCall(
- make_scoped_ptr(new int64_t(Key::KEY_TYPE_SALTED_SHA256)),
- make_scoped_ptr(new std::string(kSalt)));
+ base::WrapUnique(new int64_t(Key::KEY_TYPE_SALTED_SHA256)),
+ base::WrapUnique(new std::string(kSalt)));
ExpectMountExCall(false /* expect_create_attempt */);
auth_->AuthenticateToLogin(NULL, user_context_);
@@ -779,8 +784,8 @@ TEST_F(CryptohomeAuthenticatorTest, FailLoginWithMissingSalt) {
// pre-hashed key was used to create the cryptohome but without the required
// salt.
ExpectGetKeyDataExCall(
- make_scoped_ptr(new int64_t(Key::KEY_TYPE_SALTED_SHA256)),
- scoped_ptr<std::string>());
+ base::WrapUnique(new int64_t(Key::KEY_TYPE_SALTED_SHA256)),
+ std::unique_ptr<std::string>());
auth_->AuthenticateToLogin(NULL, user_context_);
base::RunLoop().Run();
« no previous file with comments | « chrome/browser/chromeos/login/auth/chrome_login_performer.h ('k') | chrome/browser/chromeos/login/auth/mount_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698