Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/chromeos/external_metrics_unittest.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/external_metrics_unittest.cc
diff --git a/chrome/browser/chromeos/external_metrics_unittest.cc b/chrome/browser/chromeos/external_metrics_unittest.cc
index 3f937d17e092c69baeb967cfd812489046ef65b0..e0879e3373a041be5a965437dbfda1f739ff19e9 100644
--- a/chrome/browser/chromeos/external_metrics_unittest.cc
+++ b/chrome/browser/chromeos/external_metrics_unittest.cc
@@ -2,12 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/chromeos/external_metrics.h"
+
+#include <memory>
+
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
-#include "base/memory/scoped_ptr.h"
#include "base/metrics/statistics_recorder.h"
#include "base/test/histogram_tester.h"
-#include "chrome/browser/chromeos/external_metrics.h"
#include "components/metrics/serialization/metric_sample.h"
#include "components/metrics/serialization/serialization_utils.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -38,7 +40,7 @@ TEST_F(ExternalMetricsTest, HandleMissingFile) {
TEST_F(ExternalMetricsTest, CanReceiveHistogram) {
base::HistogramTester histogram_tester;
- scoped_ptr<metrics::MetricSample> hist =
+ std::unique_ptr<metrics::MetricSample> hist =
metrics::MetricSample::HistogramSample("foo", 2, 1, 100, 10);
EXPECT_TRUE(metrics::SerializationUtils::WriteMetricToFile(
@@ -53,7 +55,7 @@ TEST_F(ExternalMetricsTest, IncorrectHistogramsAreDiscarded) {
base::HistogramTester histogram_tester;
// Malformed histogram (min > max).
- scoped_ptr<metrics::MetricSample> hist =
+ std::unique_ptr<metrics::MetricSample> hist =
metrics::MetricSample::HistogramSample("bar", 30, 200, 20, 10);
EXPECT_TRUE(metrics::SerializationUtils::WriteMetricToFile(
« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc ('k') | chrome/browser/chromeos/feedback_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698