chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc - Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/cloud_external_data_policy_observer.h ('k') | chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc

diff --git a/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc b/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc

index 8b2d4fd67463c35a97326d43cd5a525222ebae70..be184adba3c932d0b3b77521d4530dafe4a9946b 100644

--- a/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc

+++ b/chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc

@@ -115,8 +115,7 @@ void CloudExternalDataPolicyObserver::Delegate::OnExternalDataCleared(

void CloudExternalDataPolicyObserver::Delegate::OnExternalDataFetched(

const std::string& policy,

const std::string& user_id,

- scoped_ptr<std::string> data) {

+ std::unique_ptr<std::string> data) {}

CloudExternalDataPolicyObserver::Delegate::~Delegate() {

}

@@ -308,7 +307,7 @@ void CloudExternalDataPolicyObserver::HandleExternalDataPolicyUpdate(

void CloudExternalDataPolicyObserver::OnExternalDataFetched(

const std::string& user_id,

- scoped_ptr<std::string> data) {

+ std::unique_ptr<std::string> data) {

FetchWeakPtrMap::iterator it = fetch_weak_ptrs_.find(user_id);

DCHECK(it != fetch_weak_ptrs_.end());

fetch_weak_ptrs_.erase(it);