Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc

Issue 1870793002: Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/file_system_provider/operations/open_file.h" 5 #include "chrome/browser/chromeos/file_system_provider/operations/open_file.h"
6 6
7 #include <memory>
7 #include <string> 8 #include <string>
8 #include <vector> 9 #include <vector>
9 10
10 #include "base/files/file.h" 11 #include "base/files/file.h"
11 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
12 #include "base/macros.h" 13 #include "base/macros.h"
13 #include "base/memory/scoped_ptr.h"
14 #include "base/memory/scoped_vector.h" 14 #include "base/memory/scoped_vector.h"
15 #include "chrome/browser/chromeos/file_system_provider/operations/test_util.h" 15 #include "chrome/browser/chromeos/file_system_provider/operations/test_util.h"
16 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_inte rface.h" 16 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_inte rface.h"
17 #include "chrome/common/extensions/api/file_system_provider.h" 17 #include "chrome/common/extensions/api/file_system_provider.h"
18 #include "chrome/common/extensions/api/file_system_provider_capabilities/file_sy stem_provider_capabilities_handler.h" 18 #include "chrome/common/extensions/api/file_system_provider_capabilities/file_sy stem_provider_capabilities_handler.h"
19 #include "chrome/common/extensions/api/file_system_provider_internal.h" 19 #include "chrome/common/extensions/api/file_system_provider_internal.h"
20 #include "extensions/browser/event_router.h" 20 #include "extensions/browser/event_router.h"
21 #include "storage/browser/fileapi/async_file_util.h" 21 #include "storage/browser/fileapi/async_file_util.h"
22 #include "testing/gtest/include/gtest/gtest.h" 22 #include "testing/gtest/include/gtest/gtest.h"
23 23
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 OPEN_FILE_MODE_READ, 178 OPEN_FILE_MODE_READ,
179 base::Bind(&CallbackLogger::OnOpenFile, 179 base::Bind(&CallbackLogger::OnOpenFile,
180 base::Unretained(&callback_logger))); 180 base::Unretained(&callback_logger)));
181 open_file.SetDispatchEventImplForTesting( 181 open_file.SetDispatchEventImplForTesting(
182 base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl, 182 base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
183 base::Unretained(&dispatcher))); 183 base::Unretained(&dispatcher)));
184 184
185 EXPECT_TRUE(open_file.Execute(kRequestId)); 185 EXPECT_TRUE(open_file.Execute(kRequestId));
186 186
187 open_file.OnSuccess(kRequestId, 187 open_file.OnSuccess(kRequestId,
188 scoped_ptr<RequestValue>(new RequestValue()), 188 std::unique_ptr<RequestValue>(new RequestValue()),
189 false /* has_more */); 189 false /* has_more */);
190 ASSERT_EQ(1u, callback_logger.events().size()); 190 ASSERT_EQ(1u, callback_logger.events().size());
191 CallbackLogger::Event* event = callback_logger.events()[0]; 191 CallbackLogger::Event* event = callback_logger.events()[0];
192 EXPECT_EQ(base::File::FILE_OK, event->result()); 192 EXPECT_EQ(base::File::FILE_OK, event->result());
193 EXPECT_LT(0, event->file_handle()); 193 EXPECT_LT(0, event->file_handle());
194 } 194 }
195 195
196 TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) { 196 TEST_F(FileSystemProviderOperationsOpenFileTest, OnError) {
197 util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */); 197 util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
198 CallbackLogger callback_logger; 198 CallbackLogger callback_logger;
199 199
200 OpenFile open_file(NULL, file_system_info_, base::FilePath(kFilePath), 200 OpenFile open_file(NULL, file_system_info_, base::FilePath(kFilePath),
201 OPEN_FILE_MODE_READ, 201 OPEN_FILE_MODE_READ,
202 base::Bind(&CallbackLogger::OnOpenFile, 202 base::Bind(&CallbackLogger::OnOpenFile,
203 base::Unretained(&callback_logger))); 203 base::Unretained(&callback_logger)));
204 open_file.SetDispatchEventImplForTesting( 204 open_file.SetDispatchEventImplForTesting(
205 base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl, 205 base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
206 base::Unretained(&dispatcher))); 206 base::Unretained(&dispatcher)));
207 207
208 EXPECT_TRUE(open_file.Execute(kRequestId)); 208 EXPECT_TRUE(open_file.Execute(kRequestId));
209 209
210 open_file.OnError(kRequestId, 210 open_file.OnError(kRequestId,
211 scoped_ptr<RequestValue>(new RequestValue()), 211 std::unique_ptr<RequestValue>(new RequestValue()),
212 base::File::FILE_ERROR_TOO_MANY_OPENED); 212 base::File::FILE_ERROR_TOO_MANY_OPENED);
213 ASSERT_EQ(1u, callback_logger.events().size()); 213 ASSERT_EQ(1u, callback_logger.events().size());
214 CallbackLogger::Event* event = callback_logger.events()[0]; 214 CallbackLogger::Event* event = callback_logger.events()[0];
215 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result()); 215 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
216 ASSERT_EQ(0, event->file_handle()); 216 ASSERT_EQ(0, event->file_handle());
217 } 217 }
218 218
219 } // namespace operations 219 } // namespace operations
220 } // namespace file_system_provider 220 } // namespace file_system_provider
221 } // namespace chromeos 221 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698