Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1870783003: Notifies the IME extension for IME ready with onActivate/onFocus events at start. (Closed)

Created:
4 years, 8 months ago by Azure Wei
Modified:
4 years, 8 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notifies the IME extension for IME ready with onActivate/onFocus events at start. BUG=517773 TEST=None Committed: https://crrev.com/96e3d965e31d8a9d794dc9b8c046467223a3ec6f Cr-Commit-Position: refs/heads/master@{#386003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Azure Wei
Hello Shu, please review this cl. Thanks!
4 years, 8 months ago (2016-04-08 03:41:31 UTC) #3
Shu Chen
lgtm
4 years, 8 months ago (2016-04-08 04:47:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870783003/1
4 years, 8 months ago (2016-04-08 04:47:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 06:03:39 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/96e3d965e31d8a9d794dc9b8c046467223a3ec6f Cr-Commit-Position: refs/heads/master@{#386003}
4 years, 8 months ago (2016-04-08 06:04:42 UTC) #10
Azure Wei
4 years, 8 months ago (2016-04-13 01:49:28 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1881233004/ by azurewei@chromium.org.

The reason for reverting is: This cl leads to to two times of
input.ime.onActivate event triggered.
The extension should add input.ime.onFocus event before input.ime.onActivate
event. And no need to add this cl..

Powered by Google App Engine
This is Rietveld 408576698