Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1870773002: [4fGradient] Veto blitters for non-opaque paints (Closed)

Created:
4 years, 8 months ago by f(malita)
Modified:
4 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[4fGradient] Veto blitters for non-opaque paints The current blitters don't support SrcOver, so we must ensure the colors are opaque. Checking shader.colorsAreOpaque() is not enough as it doesn't reflect the paint alpha. Instead we should check for context flags & kOpaqueAlpha_Flag, which is only set when both the color stops AND the paint are opaque. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1870773002 Committed: https://skia.googlesource.com/skia/+/eadf3cf899d87b9c96fb7ede5c8eb54f63900193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/effects/gradients/Sk4fLinearGradient.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
f(malita)
4 years, 8 months ago (2016-04-07 19:50:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870773002/1
4 years, 8 months ago (2016-04-07 19:50:25 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-07 19:50:26 UTC) #5
reed1
lgtm
4 years, 8 months ago (2016-04-07 19:55:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 20:16:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eadf3cf899d87b9c96fb7ede5c8eb54f63900193

Powered by Google App Engine
This is Rietveld 408576698