Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1870763003: [turbofan] Remove some clever-but-wrong bits from select lowering. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove some clever-but-wrong bits from select lowering. BUG=chromium:600593 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/03975befe31fbc357928fbdc8cf8cf49533eada1 Cr-Commit-Position: refs/heads/master@{#35347}

Patch Set 1 #

Patch Set 2 : Prune headers #

Patch Set 3 : Update (= remove) the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -133 lines) Patch
M src/compiler/select-lowering.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/select-lowering.cc View 2 chunks +4 lines, -49 lines 0 comments Download
A test/mjsunit/compiler/regress-600593.js View 1 chunk +21 lines, -0 lines 0 comments Download
D test/unittests/compiler/select-lowering-unittest.cc View 1 2 1 chunk +0 lines, -74 lines 0 comments Download
M test/unittests/unittests.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-04-08 07:39:28 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-08 07:40:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870763003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870763003/40001
4 years, 8 months ago (2016-04-08 07:59:50 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-08 08:25:59 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 08:26:22 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03975befe31fbc357928fbdc8cf8cf49533eada1
Cr-Commit-Position: refs/heads/master@{#35347}

Powered by Google App Engine
This is Rietveld 408576698