Ensure that the cursor visibility state is restored correctly on CursorManager creation.

Ensure that the cursor visibility state is restored correctly on CursorManager creation.

We hide the cursor when we receive a touch down message and show it when we receive a normal mouse
message, i.e. a mouse message which is not synthesized by Windows in response to touch.

The CursorManager is the class which manages the cursor visibility state, etc. We have a single instance
of this class which has shared by all desktop chrome windows. When all the windows are closed, the cursor
manager instance is destroyed. When a new CursorManager instance is created on the same thread, it sets
the cursor visibility as true, regardless of the last visibility state, i.e. a user may have touched the window
and then closed it, etc.

Fix is to remember the last state of the cursor in a static variable in the CursorManager class, and use it to
initialize any new CursorManager instances.

BUG=447153
TEST=Covered by wm unittest CursorManagerCreateDestroyTest.VisibilityTest

Committed: https://crrev.com/712e1caac53b0cd18f48046c877bdeb2dad55fdb
Cr-Commit-Position: refs/heads/master@{#386156}

[ananta, 2016-04-08 00:59:18]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-04-08 16:12:58]

LGTM

[ananta, 2016-04-08 18:50:52]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-04-08 18:51:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870743003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870743003/1

[commit-bot: I haz the power, 2016-04-08 18:58:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-08 18:59:34]

Description was changed from

==========
Ensure that the cursor visibility state is restored correctly on CursorManager
creation.

We hide the cursor when we receive a touch down message and show it when we
receive a normal mouse
message, i.e. a mouse message which is not synthesized by Windows in response to
touch.

The CursorManager is the class which manages the cursor visibility state, etc.
We have a single instance
of this class which has shared by all desktop chrome windows. When all the
windows are closed, the cursor
manager instance is destroyed. When a new CursorManager instance is created on
the same thread, it sets
the cursor visibility as true, regardless of the last visibility state, i.e. a
user may have touched the window
and then closed it, etc.

Fix is to remember the last state of the cursor in a static variable in the
CursorManager class, and use it to
initialize any new CursorManager instances.

BUG=447153
TEST=Covered by wm unittest CursorManagerCreateDestroyTest.VisibilityTest
==========

to

==========
Ensure that the cursor visibility state is restored correctly on CursorManager
creation.

We hide the cursor when we receive a touch down message and show it when we
receive a normal mouse
message, i.e. a mouse message which is not synthesized by Windows in response to
touch.

The CursorManager is the class which manages the cursor visibility state, etc.
We have a single instance
of this class which has shared by all desktop chrome windows. When all the
windows are closed, the cursor
manager instance is destroyed. When a new CursorManager instance is created on
the same thread, it sets
the cursor visibility as true, regardless of the last visibility state, i.e. a
user may have touched the window
and then closed it, etc.

Fix is to remember the last state of the cursor in a static variable in the
CursorManager class, and use it to
initialize any new CursorManager instances.

BUG=447153
TEST=Covered by wm unittest CursorManagerCreateDestroyTest.VisibilityTest

Committed: https://crrev.com/712e1caac53b0cd18f48046c877bdeb2dad55fdb
Cr-Commit-Position: refs/heads/master@{#386156}
==========

[commit-bot: I haz the power, 2016-04-08 18:59:35]

Patchset 1 (id:??) landed as
https://crrev.com/712e1caac53b0cd18f48046c877bdeb2dad55fdb
Cr-Commit-Position: refs/heads/master@{#386156}