content/browser/service_worker/foreign_fetch_request_handler.cc - Issue 1870743002: Foreign fetch should not intercept same origin or main resource requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/foreign_fetch_request_handler.cc

Issue 1870743002: Foreign fetch should not intercept same origin or main resource requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add same origin test, and unregister service workers in tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/foreign-fetch-basics.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/foreign_fetch_request_handler.cc

diff --git a/content/browser/service_worker/foreign_fetch_request_handler.cc b/content/browser/service_worker/foreign_fetch_request_handler.cc

index ec4d5cdb6b858e64fdf55d6874c8923a42a7754f..acaf1c6b3f292050ac96283abeef903d060b8a7e 100644

--- a/content/browser/service_worker/foreign_fetch_request_handler.cc

+++ b/content/browser/service_worker/foreign_fetch_request_handler.cc

@@ -67,6 +67,11 @@ void ForeignFetchRequestHandler::InitializeHandler(

return;

}

+ if (request->initiator().IsSameOriginWith(url::Origin(request->url())))

+ return;

+ if (ServiceWorkerUtils::IsMainResourceType(resource_type))

+ return;

// Any more precise checks to see if the request should be intercepted are

// asynchronous, so just create our handler in all cases.

scoped_ptr<ForeignFetchRequestHandler> handler(new ForeignFetchRequestHandler(