third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-worker-helper.html - Issue 1870743002: Foreign fetch should not intercept same origin or main resource requests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/install-worker-helper.html

Issue 1870743002: Foreign fetch should not intercept same origin or main resource requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="test-helpers.js"></script>

	3 <script>

	4 window.addEventListener('message', event => {

	5 var port = event.ports[0];

	6 navigator.serviceWorker.register(event.data.worker, event.data.options)
	falken 2016/04/08 01:28:29 We usually unregister before register to be resili We usually unregister before register to be resilient to mess from other tests. Marijn Kruisselbrink 2016/04/08 17:20:36 Good point, added an unregister call before the re Show quoted text On 2016/04/08 at 01:28:29, falken wrote: > We usually unregister before register to be resilient to mess from other tests. Good point, added an unregister call before the register.
	7 .then(r => new Promise(resolve => {

	8 var worker = r.installing;

	9 worker.addEventListener('statechange', () => {

	10 if (worker.state === 'activated') resolve();

	11 });

	12 }))

	13 .then(() => port.postMessage('success'))

	14 .catch((e) => port.postMessage('failure:' + e));

	15 });
	falken 2016/04/08 01:28:29 Can you unregister these workers when the test end Can you unregister these workers when the test ends? Marijn Kruisselbrink 2016/04/08 17:20:36 I added an unload handler on the iframe to unregis Show quoted text On 2016/04/08 at 01:28:29, falken wrote: > Can you unregister these workers when the test ends? I added an unload handler on the iframe to unregister the worker when the iframe is destroyed.
	16 </script>

OLD	NEW

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/foreign-fetch-worker.js ('k') | no next file » | no next file with comments »