Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1870733002: Fix the parser to handle generic type arguments in named constructor invocations (issue 26183) (Closed)

Created:
4 years, 8 months ago by Brian Wilkerson
Modified:
4 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the parser to handle generic type arguments in named constructor invocations (issue 26183) R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/03384b23197e257cb9a3921ca329451530208ee0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +140 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 8 months ago (2016-04-07 17:54:10 UTC) #2
Jennifer Messerly
lgtm
4 years, 8 months ago (2016-04-07 18:02:41 UTC) #3
Brian Wilkerson
4 years, 8 months ago (2016-04-07 18:05:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03384b23197e257cb9a3921ca329451530208ee0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698