Refactoring display configuration state to allow generic state objects

ui/display/display.gyp

Index: ui/display/display.gyp
diff --git a/ui/display/display.gyp b/ui/display/display.gyp
index 4d32fcfda3b06f53c316d445c43340c4f4a394fa..c970965c7448764c54eaeb41a6428f15dff98edd 100644
--- a/ui/display/display.gyp
+++ b/ui/display/display.gyp
@@ -12,9 +12,68 @@
       'type': '<(component)',
       'dependencies': [
         '<(DEPTH)/base/base.gyp:base',
+        '<(DEPTH)/ui/gfx/gfx.gyp:gfx_geometry',
+      ],
+      'defines': [
+        'DISPLAY_IMPLEMENTATION',
       ],
       'sources': [
+        'chromeos/display_mode.cc',
+        'chromeos/display_mode.h',
+        'chromeos/display_snapshot.cc',
+        'chromeos/display_snapshot.h',
+        'chromeos/display_util.cc',
+        'chromeos/display_util.h',
+        'chromeos/native_display_delegate.h',
+        'chromeos/native_display_observer.h',
+        'chromeos/x11/display_mode_x11.cc',
+        'chromeos/x11/display_mode_x11.h',
+        'chromeos/x11/display_snapshot_x11.cc',
+        'chromeos/x11/display_snapshot_x11.h',
+        'chromeos/x11/native_display_delegate_x11.cc',
+        'chromeos/x11/native_display_delegate_x11.h',
+        'chromeos/x11/native_display_event_dispatcher_x11.cc',
+        'chromeos/x11/native_display_event_dispatcher_x11.h',
         'display_constants.h',
+        'display_export.h',
+      ],
+      'conditions': [
+        ['use_x11 == 1', {
+          'dependencies': [
+            '<(DEPTH)/build/linux/system.gyp:x11',
+            '<(DEPTH)/build/linux/system.gyp:xrandr',
+          ],
+        }],
+      ],
+    },
+    {
+      'target_name': 'display_test_util',
+      'type': '<(component)',
+      'dependencies': [
+        '<(DEPTH)/base/base.gyp:base',
+        '<(DEPTH)/ui/gfx/gfx.gyp:gfx_geometry',
+        'display',
+      ],
+      'defines': [
+        'DISPLAY_IMPLEMENTATION',
+      ],
+      'sources': [
+        'chromeos/test/test_display_snapshot.cc',
+        'chromeos/test/test_display_snapshot.h',
+      ],
+    },
+    {
+      'target_name': 'display_unittests',

[dnicoara, 2014/03/05 19:52:46]

I'm wondering if this needs to be added to a list or target to be picked up by
try-bots?

[Daniel Erat, 2014/03/06 00:55:04]

i don't know anything about this, but maybe build/all.gyp?

[sadrul, 2014/03/06 01:00:31]

build/all.gyp can be useful to make sure that this target gets built if you add
this as a dependency to aura_builder/chrome_builder_tests targets.

To actually run the tests on the bots, you need something like this:
https://codereview.chromium.org/66343003/ (this may have changed recently, I am
not sure).

+      'type': 'executable',
+      'dependencies': [
+        '<(DEPTH)/base/base.gyp:run_all_unittests',
+        '<(DEPTH)/base/base.gyp:test_support_base',
+        '<(DEPTH)/testing/gtest.gyp:gtest',
+        '<(DEPTH)/ui/gfx/gfx.gyp:gfx_geometry',
+        'display',
+      ],
+      'sources': [
+        'chromeos/x11/native_display_event_dispatcher_x11_unittest.cc',
       ],
     },
   ],