Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18707002: Reduce number of header includes in SVG (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
Reviewers:
pdr., krit, Stephen Chennney
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, lgombos
Visibility:
Public.

Description

Reduce number of header includes in SVG Reduce number of header includes in SVG. In particular, SVGAnimatedPropertyMacros.h no longer brings SVGElement.h header include. This means that the SVGElement class can now have animated properties. This patch is a prerequirement to merge SVGStyledElement into SVGElement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153682

Patch Set 1 #

Patch Set 2 : Attempt to fix bots #

Total comments: 4

Patch Set 3 : Add Samsung copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -157 lines) Patch
M Source/core/core.gypi View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/ReferenceFilterBuilder.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/GradientAttributes.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.h View 1 2 4 chunks +8 lines, -72 lines 0 comments Download
A Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGElementInstanceList.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGElementInstanceList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGElementRareData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.h View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFontData.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGFontData.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFontElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGGlyphMap.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGMPathElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathBlender.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathBlender.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPathBuilder.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathParser.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathTraversalStateBuilder.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathTraversalStateBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPathUtilities.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGPointList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGStyledElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGTests.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGTransformable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGURIReference.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGURIReference.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGVKernElement.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/svg/SVGVKernElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGZoomAndPan.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 1 2 4 chunks +5 lines, -36 lines 0 comments Download
A Source/core/svg/properties/SVGAnimatedProperty.cpp View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyMacros.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/svg/properties/SVGAttributeToPropertyMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGAttributeToPropertyMap.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/properties/SVGListProperty.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-05 10:30:47 UTC) #1
Stephen Chennney
Everyone's having fun with includes. LGTM https://codereview.chromium.org/18707002/diff/3001/Source/core/svg/SVGAnimatedTypeAnimator.cpp File Source/core/svg/SVGAnimatedTypeAnimator.cpp (right): https://codereview.chromium.org/18707002/diff/3001/Source/core/svg/SVGAnimatedTypeAnimator.cpp#newcode2 Source/core/svg/SVGAnimatedTypeAnimator.cpp:2: * Copyright (C) ...
7 years, 5 months ago (2013-07-08 14:08:39 UTC) #2
do-not-use
On 2013/07/08 14:08:39, Stephen Chenney wrote: > Everyone's having fun with includes. > > LGTM ...
7 years, 5 months ago (2013-07-08 14:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18707002/11001
7 years, 5 months ago (2013-07-08 14:32:07 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 16:05:38 UTC) #5
Message was sent while issue was closed. 
Change committed as 153682

Powered by Google App Engine
This is Rietveld 408576698