Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1870693002: [debugging] change default array maps elements kind to some more sane values. (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugging] change default array maps elements kind to some more sane values. BUG= Committed: https://crrev.com/130ccb953c87a7b337b69b4a9a18f6bea09295a0 Cr-Commit-Position: refs/heads/master@{#36206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/heap/heap.cc View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Camillo Bruni
PTAL
4 years, 8 months ago (2016-04-07 15:05:59 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-08 07:38:55 UTC) #3
Toon Verwaest
lgtm
4 years, 7 months ago (2016-05-12 11:08:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870693002/1
4 years, 7 months ago (2016-05-12 11:25:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 11:55:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 11:56:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/130ccb953c87a7b337b69b4a9a18f6bea09295a0
Cr-Commit-Position: refs/heads/master@{#36206}

Powered by Google App Engine
This is Rietveld 408576698