Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 1870663002: Reland main thread position sticky implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix crash resulting from PaintLayer::removeOnlyThisLayer Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections. 192 // object wedged in between them. Auto z-index also becomes 0 for objects th at specify transforms/masks/reflections.
193 if (style.hasAutoZIndex() && ((element && element->document().documentElemen t() == element) 193 if (style.hasAutoZIndex() && ((element && element->document().documentElemen t() == element)
194 || style.hasOpacity() 194 || style.hasOpacity()
195 || style.hasTransformRelatedProperty() 195 || style.hasTransformRelatedProperty()
196 || style.hasMask() 196 || style.hasMask()
197 || style.clipPath() 197 || style.clipPath()
198 || style.boxReflect() 198 || style.boxReflect()
199 || style.hasFilterInducingProperty() 199 || style.hasFilterInducingProperty()
200 || style.hasBlendMode() 200 || style.hasBlendMode()
201 || style.hasIsolation() 201 || style.hasIsolation()
202 || style.position() == FixedPosition 202 || style.hasViewportConstrainedPosition()
203 || isInTopLayer(element, style) 203 || isInTopLayer(element, style)
204 || hasWillChangeThatCreatesStackingContext(style) 204 || hasWillChangeThatCreatesStackingContext(style)
205 || style.containsPaint())) 205 || style.containsPaint()))
206 style.setZIndex(0); 206 style.setZIndex(0);
207 207
208 if (doesNotInheritTextDecoration(style, element)) 208 if (doesNotInheritTextDecoration(style, element))
209 style.clearAppliedTextDecorations(); 209 style.clearAppliedTextDecorations();
210 210
211 style.applyTextDecorations(); 211 style.applyTextDecorations();
212 212
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 style.setDisplay(INLINE_BLOCK); 432 style.setDisplay(INLINE_BLOCK);
433 433
434 // After performing the display mutation, check table rows. We do not honor position: relative table rows or cells. 434 // After performing the display mutation, check table rows. We do not honor position: relative table rows or cells.
435 // This has been established for position: relative in CSS2.1 (and caused a crash in containingBlock() 435 // This has been established for position: relative in CSS2.1 (and caused a crash in containingBlock()
436 // on some sites). 436 // on some sites).
437 if ((style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW_G ROUP 437 if ((style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW_G ROUP
438 || style.display() == TABLE_FOOTER_GROUP || style.display() == TABLE_ROW ) 438 || style.display() == TABLE_FOOTER_GROUP || style.display() == TABLE_ROW )
439 && style.position() == RelativePosition) 439 && style.position() == RelativePosition)
440 style.setPosition(StaticPosition); 440 style.setPosition(StaticPosition);
441 441
442 // Cannot support position: sticky for table columns and column groups becau se current code is only doing
443 // background painting through columns / column groups
444 if ((style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_COLUM N)
445 && style.position() == StickyPosition)
446 style.setPosition(StaticPosition);
447
442 // writing-mode does not apply to table row groups, table column groups, tab le rows, and table columns. 448 // writing-mode does not apply to table row groups, table column groups, tab le rows, and table columns.
443 // FIXME: Table cells should be allowed to be perpendicular or flipped with respect to the table, though. 449 // FIXME: Table cells should be allowed to be perpendicular or flipped with respect to the table, though.
444 if (style.display() == TABLE_COLUMN || style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_FOOTER_GROUP 450 if (style.display() == TABLE_COLUMN || style.display() == TABLE_COLUMN_GROUP || style.display() == TABLE_FOOTER_GROUP
445 || style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW || style.display() == TABLE_ROW_GROUP 451 || style.display() == TABLE_HEADER_GROUP || style.display() == TABLE_ROW || style.display() == TABLE_ROW_GROUP
446 || style.display() == TABLE_CELL) 452 || style.display() == TABLE_CELL)
447 style.setWritingMode(parentStyle.getWritingMode()); 453 style.setWritingMode(parentStyle.getWritingMode());
448 454
449 // FIXME: Since we don't support block-flow on flexible boxes yet, disallow setting 455 // FIXME: Since we don't support block-flow on flexible boxes yet, disallow setting
450 // of block-flow to anything other than TopToBottomWritingMode. 456 // of block-flow to anything other than TopToBottomWritingMode.
451 // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support. 457 // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support.
452 if (style.getWritingMode() != TopToBottomWritingMode && (style.display() == BOX || style.display() == INLINE_BOX)) 458 if (style.getWritingMode() != TopToBottomWritingMode && (style.display() == BOX || style.display() == INLINE_BOX))
453 style.setWritingMode(TopToBottomWritingMode); 459 style.setWritingMode(TopToBottomWritingMode);
454 460
455 if (parentStyle.isDisplayFlexibleOrGridBox()) { 461 if (parentStyle.isDisplayFlexibleOrGridBox()) {
456 style.setFloating(NoFloat); 462 style.setFloating(NoFloat);
457 style.setDisplay(equivalentBlockDisplay(style.display())); 463 style.setDisplay(equivalentBlockDisplay(style.display()));
458 464
459 // We want to count vertical percentage paddings/margins on flex items b ecause our current 465 // We want to count vertical percentage paddings/margins on flex items b ecause our current
460 // behavior is different from the spec and we want to gather compatibili ty data. 466 // behavior is different from the spec and we want to gather compatibili ty data.
461 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t()) 467 if (style.paddingBefore().hasPercent() || style.paddingAfter().hasPercen t())
462 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical); 468 UseCounter::count(document, UseCounter::FlexboxPercentagePaddingVert ical);
463 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( )) 469 if (style.marginBefore().hasPercent() || style.marginAfter().hasPercent( ))
464 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal); 470 UseCounter::count(document, UseCounter::FlexboxPercentageMarginVerti cal);
465 } 471 }
466 } 472 }
467 473
468 } // namespace blink 474 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698