Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 187063007: Reland Chrome power profiler service (Closed)

Created:
6 years, 9 months ago by Pan
Modified:
6 years, 9 months ago
Reviewers:
jam, pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

This CL implemented part of chrome power profiler, including the service, data provider and observer base. BUG=337138 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255328

Patch Set 1 : original #

Total comments: 1

Patch Set 2 : Use RunLoop in test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -0 lines) Patch
A content/browser/devtools/devtools_power_handler.h View 1 chunk +36 lines, -0 lines 0 comments Download
A content/browser/devtools/devtools_power_handler.cc View 1 chunk +72 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_data_provider.h View 1 chunk +31 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_data_provider_dummy.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_event.h View 1 chunk +42 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_event.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_profiler_observer.h View 1 chunk +33 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_profiler_service.h View 1 chunk +77 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_profiler_service.cc View 1 chunk +118 lines, -0 lines 0 comments Download
A content/browser/power_profiler/power_profiler_service_unittest.cc View 1 1 chunk +138 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +9 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Pan
@pfeldman, devtools part still need your lgtm, sorry to interrupt again. @jam please review the ...
6 years, 9 months ago (2014-03-05 10:08:19 UTC) #1
jam
lgtm
6 years, 9 months ago (2014-03-05 22:24:50 UTC) #2
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-05 22:52:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/187063007/20001
6 years, 9 months ago (2014-03-05 22:52:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/187063007/20001
6 years, 9 months ago (2014-03-06 00:08:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 00:30:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 00:30:50 UTC) #7
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-06 00:56:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/187063007/20001
6 years, 9 months ago (2014-03-06 00:59:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/187063007/20001
6 years, 9 months ago (2014-03-06 02:53:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/187063007/20001
6 years, 9 months ago (2014-03-06 03:18:26 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 04:01:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 04:01:35 UTC) #13
Pan
The CQ bit was checked by pan.deng@intel.com
6 years, 9 months ago (2014-03-06 04:51:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/187063007/20001
6 years, 9 months ago (2014-03-06 04:52:22 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 13:59:33 UTC) #16
Message was sent while issue was closed.
Change committed as 255328

Powered by Google App Engine
This is Rietveld 408576698