Moved all state from SiteIsolationPolicy out to the PendingRequestInfo struct in the ResourceSchedu…

Moved all state from SiteIsolationPolicy out to the PendingRequestInfo struct in the ResourceScheduler

This removes a few redundant map lookups, simplifies the logic, and also paves the way for using this class from multiple threads.
R=creis@chromium.org
BUG=277124
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255389

[oystein (OOO til 10th of July), 2014-03-05 00:58:11]

Slightly delayed, this is a warmup CL to the parserthread changes I emailed
about a month ago. ptal :)

[oystein (OOO til 10th of July), 2014-03-05 00:58:52]

On 2014/03/05 00:58:11, Oystein wrote:
> Slightly delayed, this is a warmup CL to the parserthread changes I emailed
> about a month ago. ptal :)

(Turned out to be a better solution IMO than moving this check to the I/O
thread).

[Charlie Reis, 2014-03-05 18:22:44]

Ah, this is great.  LGTM!

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
File content/child/site_isolation_policy.cc (right):

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
content/child/site_isolation_policy.cc:204: 
nit: Remove extra line.

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
File content/child/site_isolation_policy.h (right):

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
content/child/site_isolation_policy.h:88: // the bookkeeping data.
Maybe mention that the data is stored in the returned metadata struct, whose
lifetime matches the request.  Then we don't need the last sentence about
OnRequestComplete.

[oystein (OOO til 10th of July), 2014-03-05 19:23:39]

Awesome, thanks :)

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
File content/child/site_isolation_policy.cc (right):

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
content/child/site_isolation_policy.cc:204: 
On 2014/03/05 18:22:44, Charlie Reis wrote:
> nit: Remove extra line.

Done.

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
File content/child/site_isolation_policy.h (right):

https://codereview.chromium.org/187063006/diff/1/content/child/site_isolation...
content/child/site_isolation_policy.h:88: // the bookkeeping data.
On 2014/03/05 18:22:44, Charlie Reis wrote:
> Maybe mention that the data is stored in the returned metadata struct, whose
> lifetime matches the request.  Then we don't need the last sentence about
> OnRequestComplete.

Done.

[oystein (OOO til 10th of July), 2014-03-05 19:23:42]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2014-03-05 19:25:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/187063006/20001

[commit-bot: I haz the power, 2014-03-05 19:35:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 19:36:00]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, gfx_unittests,
google_apis_unittests, gpu_unittests, installer_util_unittests, ipc_tests,
jingle_unittests, media_unittests, mini_installer_test, nacl_integration,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[oystein (OOO til 10th of July), 2014-03-05 19:40:11]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2014-03-05 19:47:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/187063006/20001

[commit-bot: I haz the power, 2014-03-05 23:56:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/187063006/20001

[commit-bot: I haz the power, 2014-03-06 02:41:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/187063006/20001

[commit-bot: I haz the power, 2014-03-06 03:11:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/187063006/20001

[commit-bot: I haz the power, 2014-03-06 06:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 06:07:00]

Retried try job too often on win_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[oystein (OOO til 10th of July), 2014-03-06 17:35:29]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2014-03-06 17:38:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/187063006/20001

[commit-bot: I haz the power, 2014-03-06 17:40:14]

Change committed as 255389