Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1870613002: Revert of [heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
CC:
ulan, Hannes Payer (out of office), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. (patchset #4 id:60001 of https://codereview.chromium.org/1855943002/ ) Reason for revert: Reverting because of https://bugs.chromium.org/p/chromium/issues/detail?id=601204 Original issue's description: > [heap] Respect idle deadline in AdvanceIncrementalMarking more carefully. > > Committed: https://crrev.com/0eb53167f492a44d26b68c2197e37452f70c3a4f > Cr-Commit-Position: refs/heads/master@{#35288} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d8bc471b4a8d8dba55cc21917edb8afb94faf597 Cr-Commit-Position: refs/heads/master@{#35319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Revert of [heap] Respect idle deadline in AdvanceIncrementalMarking more carefully.
4 years, 8 months ago (2016-04-07 07:14:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870613002/1
4 years, 8 months ago (2016-04-07 07:14:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 07:14:23 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 07:14:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8bc471b4a8d8dba55cc21917edb8afb94faf597
Cr-Commit-Position: refs/heads/master@{#35319}

Powered by Google App Engine
This is Rietveld 408576698