Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 18706003: Get rid of SVGPathSeg* special casing in the bindings generator (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, pdr, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, Stephen Chennney, Nate Chapin, lgombos, kojih
Visibility:
Public.

Description

Get rid of SVGPathSeg* special casing in the bindings generator Have one header per SVGPathSeg* type so that we no longer need special casing for them in the JSC bindings generator. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -748 lines) Patch
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +18 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 1 chunk +18 lines, -9 lines 0 comments Download
M Source/core/svg/SVGPathSegArc.h View 1 chunk +0 lines, -36 lines 0 comments Download
A + Source/core/svg/SVGPathSegArcAbs.h View 2 chunks +12 lines, -11 lines 0 comments Download
A + Source/core/svg/SVGPathSegArcRel.h View 2 chunks +12 lines, -11 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubic.h View 1 chunk +0 lines, -36 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoCubicAbs.h View 2 chunks +12 lines, -11 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoCubicRel.h View 2 chunks +12 lines, -11 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmooth.h View 1 chunk +0 lines, -36 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.h View 2 chunks +12 lines, -11 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.h View 2 chunks +12 lines, -11 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadratic.h View 1 chunk +0 lines, -36 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoQuadraticAbs.h View 2 chunks +12 lines, -11 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoQuadraticRel.h View 2 chunks +12 lines, -11 lines 0 comments Download
D Source/core/svg/SVGPathSegCurvetoQuadraticSmooth.h View 1 chunk +0 lines, -66 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.h View 3 chunks +3 lines, -20 lines 0 comments Download
A + Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.h View 2 chunks +3 lines, -20 lines 0 comments Download
D Source/core/svg/SVGPathSegLineto.h View 1 chunk +0 lines, -66 lines 0 comments Download
A + Source/core/svg/SVGPathSegLinetoAbs.h View 3 chunks +3 lines, -20 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontal.h View 1 chunk +0 lines, -36 lines 0 comments Download
A + Source/core/svg/SVGPathSegLinetoHorizontalAbs.h View 3 chunks +4 lines, -40 lines 0 comments Download
A + Source/core/svg/SVGPathSegLinetoHorizontalRel.h View 2 chunks +4 lines, -40 lines 0 comments Download
A + Source/core/svg/SVGPathSegLinetoRel.h View 2 chunks +3 lines, -20 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVertical.h View 1 chunk +0 lines, -36 lines 0 comments Download
A + Source/core/svg/SVGPathSegLinetoVerticalAbs.h View 2 chunks +12 lines, -11 lines 0 comments Download
A + Source/core/svg/SVGPathSegLinetoVerticalRel.h View 2 chunks +12 lines, -11 lines 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.cpp View 1 chunk +18 lines, -9 lines 0 comments Download
D Source/core/svg/SVGPathSegMoveto.h View 1 chunk +0 lines, -66 lines 0 comments Download
A + Source/core/svg/SVGPathSegMovetoAbs.h View 3 chunks +3 lines, -20 lines 0 comments Download
A + Source/core/svg/SVGPathSegMovetoRel.h View 2 chunks +3 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
Adapted from <http://trac.webkit.org/changeset/152565>.
7 years, 5 months ago (2013-07-11 13:16:54 UTC) #1
haraken
This CL just split existing code to other files, LGTM. Thanks for doing this. kojih@ ...
7 years, 5 months ago (2013-07-11 13:22:23 UTC) #2
do-not-use
On 2013/07/11 13:22:23, haraken wrote: > This CL just split existing code to other files, ...
7 years, 5 months ago (2013-07-11 13:25:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18706003/1
7 years, 5 months ago (2013-07-11 13:34:05 UTC) #4
haraken
On 2013/07/11 13:25:55, Christophe Dumez wrote: > On 2013/07/11 13:22:23, haraken wrote: > > This ...
7 years, 5 months ago (2013-07-11 13:36:10 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 15:08:18 UTC) #6
Message was sent while issue was closed.
Change committed as 154009

Powered by Google App Engine
This is Rietveld 408576698