Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1870583002: Update the behavior of ShadowRoot.activeElement to match the latest spec (Closed)

Created:
4 years, 8 months ago by hayato
Modified:
4 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the behavior of ShadowRoot.activeElement to match the latest spec The spec change is: https://github.com/w3c/webcomponents/commit/15a203c8393aef0df7223ab1d43406aa11a7e71e - v1 shadow tree should have the new behavior. - v0 shadow tree will not change the behavior for a compatibility. BUG=601303 Committed: https://crrev.com/4902d6ccd120be91c417b891b13d6fdb0b4e8e4c Cr-Commit-Position: refs/heads/master@{#386002}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/shadow-dom/active-element.html View 1 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870583002/1
4 years, 8 months ago (2016-04-07 05:07:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 06:47:04 UTC) #4
hayato
PTAL
4 years, 8 months ago (2016-04-07 09:25:37 UTC) #6
kochi
lgtm https://codereview.chromium.org/1870583002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/active-element.html File third_party/WebKit/LayoutTests/shadow-dom/active-element.html (right): https://codereview.chromium.org/1870583002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/active-element.html#newcode61 third_party/WebKit/LayoutTests/shadow-dom/active-element.html:61: }, "activeElement for a node in a nested ...
4 years, 8 months ago (2016-04-08 01:23:58 UTC) #7
hayato
fixed
4 years, 8 months ago (2016-04-08 04:45:51 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870583002/20001
4 years, 8 months ago (2016-04-08 04:45:55 UTC) #10
hayato
https://codereview.chromium.org/1870583002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/active-element.html File third_party/WebKit/LayoutTests/shadow-dom/active-element.html (right): https://codereview.chromium.org/1870583002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/active-element.html#newcode61 third_party/WebKit/LayoutTests/shadow-dom/active-element.html:61: }, "activeElement for a node in a nested shadwo ...
4 years, 8 months ago (2016-04-08 04:46:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870583002/20001
4 years, 8 months ago (2016-04-08 04:46:56 UTC) #15
kochi
lgtm
4 years, 8 months ago (2016-04-08 05:26:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870583002/20001
4 years, 8 months ago (2016-04-08 05:32:34 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 05:59:47 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 06:01:21 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4902d6ccd120be91c417b891b13d6fdb0b4e8e4c
Cr-Commit-Position: refs/heads/master@{#386002}

Powered by Google App Engine
This is Rietveld 408576698