Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: lib/src/delegate/future.dart

Issue 1870543004: Add typed wrapper functions to delegate classes. (Closed) Base URL: git@github.com:dart-lang/async.git@master
Patch Set: Code review changes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 6
7 import '../typed/future.dart';
8
7 /// A wrapper that forwards calls to a [Future]. 9 /// A wrapper that forwards calls to a [Future].
8 class DelegatingFuture<T> implements Future<T> { 10 class DelegatingFuture<T> implements Future<T> {
9 /// The wrapped [Future]. 11 /// The wrapped [Future].
10 final Future<T> _future; 12 final Future<T> _future;
11 13
12 DelegatingFuture(this._future); 14 DelegatingFuture(this._future);
13 15
16 /// Creates a wrapper which throws if [future]'s value isn't an instance of
17 /// `T`.
18 ///
19 /// This soundly converts a [Future] to a `Future<T>`, regardless of its
20 /// original generic type, by asserting that its value is an instance of `T`
floitsch 2016/04/12 20:03:08 The text for this one and the EventSink should be
nweiz 2016/04/12 20:41:19 I think it's pretty different. EventSink doesn't e
21 /// whenever it's provided. If it's not, the future throws a [CastError].
22 static Future/*<T>*/ typed/*<T>*/(Future future) =>
23 future is Future/*<T>*/ ? future : new TypeSafeFuture/*<T>*/(future);
24
14 Stream<T> asStream() => _future.asStream(); 25 Stream<T> asStream() => _future.asStream();
15 26
16 Future catchError(Function onError, {bool test(Object error)}) => 27 Future catchError(Function onError, {bool test(Object error)}) =>
17 _future.catchError(onError, test: test); 28 _future.catchError(onError, test: test);
18 29
19 Future/*<S>*/ then/*<S>*/(/*=S*/ onValue(T value), {Function onError}) => 30 Future/*<S>*/ then/*<S>*/(/*=S*/ onValue(T value), {Function onError}) =>
20 _future.then(onValue, onError: onError); 31 _future.then(onValue, onError: onError);
21 32
22 Future<T> whenComplete(action()) => _future.whenComplete(action); 33 Future<T> whenComplete(action()) => _future.whenComplete(action);
23 34
24 Future<T> timeout(Duration timeLimit, {void onTimeout()}) => 35 Future<T> timeout(Duration timeLimit, {onTimeout()}) =>
floitsch 2016/04/12 20:03:08 why this change? The value of `onTimeout()` should
nweiz 2016/04/12 20:41:19 This matches dart:async's declaration. The dart:as
25 _future.timeout(timeLimit, onTimeout: onTimeout); 36 _future.timeout(timeLimit, onTimeout: onTimeout);
26 } 37 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698