Fix issues with JSON stringify replacer array

Fix issues with JSON stringify replacer array

If the replacer array contains a property key we should include the
property even if the property is non enumerable or if it is a non own
property.

String and Number wrappers in the replacer array should be treated as
string and number values.

R=yangguo@chromium.org
BUG=v8:3200, v8:3201
LOG=Y

Committed: https://code.google.com/p/v8/source/detail?r=19685

[arv (Not doing code reviews), 2014-03-04 21:43:41]

Let me know if you want me to split this into two patches?

https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
File test/mjsunit/regress/regress-3135.js (right):

https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
test/mjsunit/regress/regress-3135.js:28:
assertEquals('{"__proto__":{"__proto__":{"__proto__":null},"x":7},"x":8}',
This surprised me at first so I had to dig deep into the spec. This is the
expected result because with a replacer array we end up doing a [[Get]]. This
matches Chakra and SpiderMonkey.

[Yang, 2014-03-05 07:36:56]

On 2014/03/04 21:43:41, arv wrote:
> Let me know if you want me to split this into two patches?
> 
>
https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
> File test/mjsunit/regress/regress-3135.js (right):
> 
>
https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
> test/mjsunit/regress/regress-3135.js:28:
> assertEquals('{"__proto__":{"__proto__":{"__proto__":null},"x":7},"x":8}',
> This surprised me at first so I had to dig deep into the spec. This is the
> expected result because with a replacer array we end up doing a [[Get]]. This
> matches Chakra and SpiderMonkey.

LGTM.

[arv (Not doing code reviews), 2014-03-05 14:35:56]

On 2014/03/05 07:36:56, Yang wrote:
> On 2014/03/04 21:43:41, arv wrote:
> > Let me know if you want me to split this into two patches?
> > 
> >
>
https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
> > File test/mjsunit/regress/regress-3135.js (right):
> > 
> >
>
https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
> > test/mjsunit/regress/regress-3135.js:28:
> > assertEquals('{"__proto__":{"__proto__":{"__proto__":null},"x":7},"x":8}',
> > This surprised me at first so I had to dig deep into the spec. This is the
> > expected result because with a replacer array we end up doing a [[Get]].
This
> > matches Chakra and SpiderMonkey.
> 
> LGTM.

Thanks. Can you land this for me?

[Yang, 2014-03-06 09:46:07]

On 2014/03/05 14:35:56, arv wrote:
> On 2014/03/05 07:36:56, Yang wrote:
> > On 2014/03/04 21:43:41, arv wrote:
> > > Let me know if you want me to split this into two patches?
> > > 
> > >
> >
>
https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
> > > File test/mjsunit/regress/regress-3135.js (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/187053003/diff/30001/test/mjsunit/regress/reg...
> > > test/mjsunit/regress/regress-3135.js:28:
> > > assertEquals('{"__proto__":{"__proto__":{"__proto__":null},"x":7},"x":8}',
> > > This surprised me at first so I had to dig deep into the spec. This is the
> > > expected result because with a replacer array we end up doing a [[Get]].
> This
> > > matches Chakra and SpiderMonkey.
> > 
> > LGTM.
> 
> Thanks. Can you land this for me?

Sure.

[Yang, 2014-03-06 09:51:00]

Committed patchset #1 manually as r19685 (tree was closed).

[arv (Not doing code reviews), 2014-03-06 16:37:31]

On 2014/03/06 09:51:00, Yang wrote:
> Committed patchset #1 manually as r19685 (tree was closed).

Thanks