Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: third_party/WebKit/Source/web/tests/RunAllTests.cpp

Issue 1870503002: Making CSSValue Pool thread local (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change based on eugenis's feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/RunAllTests.cpp
diff --git a/third_party/WebKit/Source/web/tests/RunAllTests.cpp b/third_party/WebKit/Source/web/tests/RunAllTests.cpp
index ebd49150cedebe25c2ea6cc8d2d4db55bf7b7b9d..8b1298cfcfa25dad2280f898536320477778f9b2 100644
--- a/third_party/WebKit/Source/web/tests/RunAllTests.cpp
+++ b/third_party/WebKit/Source/web/tests/RunAllTests.cpp
@@ -36,6 +36,7 @@
#include "bindings/core/v8/V8GCController.h"
#include "content/test/blink_test_environment.h"
#include "mojo/edk/embedder/embedder.h"
+#include "platform/heap/ThreadState.h"
#include "platform/weborigin/SchemeRegistry.h"
#include <v8.h>
@@ -53,8 +54,10 @@ int runHelper(base::TestSuite* testSuite)
base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(&base::DoNothing));
base::RunLoop().RunUntilIdle();
- // Collect garbage in order to release mock objects referred from v8 or
- // Oilpan heap. Otherwise false mock leaks will be reported.
+ // Collect garbage (including threadspecific persistent handles) in order
+ // to release mock objects referred from v8 or Oilpan heap. Otherwise false
+ // mock leaks will be reported.
+ blink::ThreadState::current()->callThreadShutdownHooks();
blink::V8GCController::collectAllGarbageForTesting(v8::Isolate::GetCurrent());
content::TearDownBlinkTestEnvironment();
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698