Making CSSValue Pool thread local

build/sanitizers/lsan_suppressions.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains the default suppressions for LeakSanitizer.
 // You can also pass additional suppressions via LSAN_OPTIONS:
 // LSAN_OPTIONS=suppressions=/path/to/suppressions. Please refer to
 // http://dev.chromium.org/developers/testing/leaksanitizer for more info.
 
 #if defined(LEAK_SANITIZER)
 
 // Please make sure the code below declares a single string variable
 // kLSanDefaultSuppressions which contains LSan suppressions delimited by
 // newlines. See http://dev.chromium.org/developers/testing/leaksanitizer
 // for the instructions on writing suppressions.
 char kLSanDefaultSuppressions[] =
 // Intentional leak used as sanity test for Valgrind/memcheck.
 "leak:base::ToolsSanityTest_MemoryLeak_Test::TestBody\n"
 
 // ================ Leaks in third-party code ================
 
 // False positives in libfontconfig. http://crbug.com/39050
 "leak:libfontconfig\n"
+// eglibc-2.19/string creates false positive leak errors because of the same
+// reason as crbug.com/39050. The leak error stack trace, when unwind on malloc,
+// includes a call to libfontconfig. But the default stack trace is too short
+// in leak sanitizer bot to make the libfontconfig suppression works.
+"leak:eglibc-2.19/string\n"

[Evgeniy Stepanov, 2016/04/20 20:53:26]

This would break on any different version of glibc.
Also, this effectively disables all leak detection for memory allocated in
strdup, which we would really like to avoid.

Do you have the full stack trace (with fast_unwind_on_malloc=0)?

How do I reproduce it? Would running webkit_unit_tests with asan+lsan do it?

[Evgeniy Stepanov, 2016/04/20 21:13:07]

OK, I've got it. I'll fix ASan/LSan upstream so that this stacktrace would look
like
1. strdup
2. /path/to/libfontconfig.so.1

Then the existing suppression would apply.

In the mean time, please change this suppression to "leak:__strdup" and file a
bug to remove it. Make this bug blocked by crbug.com/604993.

 
 // Leaks in Nvidia's libGL.
 "leak:libGL.so\n"
 
 // TODO(eugenis): revisit NSS suppressions after the switch to BoringSSL
 // NSS leaks in CertDatabaseNSSTest tests. http://crbug.com/51988
 "leak:net::NSSCertDatabase::ImportFromPKCS12\n"
 "leak:net::NSSCertDatabase::ListCerts\n"
 "leak:net::NSSCertDatabase::DeleteCertAndKey\n"
 "leak:crypto::ScopedTestNSSDB::ScopedTestNSSDB\n"
@@ skipping 44 matching lines @@
 
 // http://crbug.com/601435
 "leak:mojo/edk/js/handle.h\n"
 
 // PLEASE READ ABOVE BEFORE ADDING NEW SUPPRESSIONS.
 
 // End of suppressions.
 ;  // Please keep this semicolon.
 
 #endif  // LEAK_SANITIZER