Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: ui/gl/gl_image_io_surface.h

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_image_io_surface.h
diff --git a/ui/gl/gl_image_io_surface.h b/ui/gl/gl_image_io_surface.h
index d8b731828f26d674176401f38b89489857fed367..62b616459f226a931a7ee51ba84cf57ec7d49e43 100644
--- a/ui/gl/gl_image_io_surface.h
+++ b/ui/gl/gl_image_io_surface.h
@@ -49,6 +49,7 @@ class GL_EXPORT GLImageIOSurface : public GLImage {
void OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,
uint64_t process_tracing_id,
const std::string& dump_name) override;
+ bool EmulatingRGB() const override;
gfx::GenericSharedMemoryId io_surface_id() const { return io_surface_id_; }
base::ScopedCFTypeRef<IOSurfaceRef> io_surface();
@@ -62,7 +63,14 @@ class GL_EXPORT GLImageIOSurface : public GLImage {
private:
const gfx::Size size_;
+
+ // The "internalformat" exposed to the command buffer, which may not be
+ // "internalformat" requested by the client.
const unsigned internalformat_;
+
+ // The "internalformat" requested by the client.
+ const unsigned client_internalformat_;
+
gfx::BufferFormat format_;
base::ScopedCFTypeRef<IOSurfaceRef> io_surface_;
gfx::GenericSharedMemoryId io_surface_id_;
« ui/gl/gl_image.h ('K') | « ui/gl/gl_image.cc ('k') | ui/gl/gl_image_io_surface.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698