Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | ui/gl/gl_image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
index d185894ade76ac4ea93c0167e11923c7c1e281a1..551e922e901171b821c47efc57d729fcab8346ef 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
@@ -51,6 +51,12 @@ New Procedures and Functions
INVALID_ENUM is generated if <usage> is not READ_WRTIE_CHROMIUM.
+ On OS X, RGB internal format is not supported, and the created
+ GpuMemoryBuffer will always have internal format RGBA. The caller is
+ responsible for handling this appropriately. The only support provided by
+ this extension is that calls to copyTexImage2D and copyTexSubImage2D will
+ perform paramter validation as if the internal format were RGB.
erikchen 2016/04/06 23:26:30 Assuming that everyone is happy with the general i
reveman 2016/04/07 13:00:56 I don't think we should have workarounds as part o
Ken Russell (switch to Gerrit) 2016/04/07 21:41:14 It seems reasonable to mention errata in the exten
+
Errors
None.
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | ui/gl/gl_image.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698