Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: ui/gl/gl_image_io_surface.h

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing braces. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_image.cc ('k') | ui/gl/gl_image_io_surface.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_image_io_surface.h
diff --git a/ui/gl/gl_image_io_surface.h b/ui/gl/gl_image_io_surface.h
index 7b68a96b6f54ac7c718de1662a80a2079440b4e2..a7d71bec4e7021ec7482238ff8095c26cb522f64 100644
--- a/ui/gl/gl_image_io_surface.h
+++ b/ui/gl/gl_image_io_surface.h
@@ -58,6 +58,7 @@ class GL_EXPORT GLImageIOSurface : public GLImage {
void OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,
uint64_t process_tracing_id,
const std::string& dump_name) override;
+ bool EmulatingRGB() const override;
gfx::GenericSharedMemoryId io_surface_id() const { return io_surface_id_; }
base::ScopedCFTypeRef<IOSurfaceRef> io_surface();
@@ -72,7 +73,14 @@ class GL_EXPORT GLImageIOSurface : public GLImage {
class RGBConverter;
const gfx::Size size_;
+
+ // The "internalformat" exposed to the command buffer, which may not be
+ // "internalformat" requested by the client.
const unsigned internalformat_;
+
+ // The "internalformat" requested by the client.
+ const unsigned client_internalformat_;
+
gfx::BufferFormat format_;
base::ScopedCFTypeRef<IOSurfaceRef> io_surface_;
base::ScopedCFTypeRef<CVPixelBufferRef> cv_pixel_buffer_;
« no previous file with comments | « ui/gl/gl_image.cc ('k') | ui/gl/gl_image_io_surface.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698