Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing braces. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index ccd593aac225d52313867ba0472f7b9312fd0adc..3c4fad310464583503e3f51d026b214dacee0681 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -129,6 +129,8 @@ class RenderbufferAttachment
return false;
}
+ bool EmulatingRGB() const override { return false; }
+
protected:
~RenderbufferAttachment() override {}
@@ -277,6 +279,10 @@ class TextureAttachment
return texture == texture_ref_.get() && level == level_;
}
+ bool EmulatingRGB() const override {
+ return texture_ref_->texture()->EmulatingRGB();
+ }
+
protected:
~TextureAttachment() override {}
@@ -537,6 +543,10 @@ GLenum Framebuffer::GetReadBufferInternalFormat() const {
return 0;
}
const Attachment* attachment = it->second.get();
+ if (attachment->EmulatingRGB()) {
+ DCHECK_EQ(static_cast<GLenum>(GL_RGBA), attachment->internal_format());
+ return GL_RGB;
+ }
return attachment->internal_format();
}
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698