Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing braces. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/webgraphicscontext3d_provider_impl.cc ('k') | gpu/command_buffer/common/capabilities.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
index d185894ade76ac4ea93c0167e11923c7c1e281a1..93af3d94275c0c7f33043b367a2e34fbb899ec33 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
@@ -51,6 +51,14 @@ New Procedures and Functions
INVALID_ENUM is generated if <usage> is not READ_WRTIE_CHROMIUM.
+ On OS X, driver bugs prevent the usage of memory buffers with RGB internal
+ format. As a workaround, the created GpuMemoryBuffer will always have
+ internal format RGBA. The caller is responsible for handling this
+ appropriately. The only support provided by this extension is that calls
+ that require parameter validation (such as copyTexImage2D and
+ copyTexSubImage2D) will perform paramter validation as if the internal
+ format were RGB.
+
Errors
None.
@@ -62,3 +70,4 @@ New State
Revision History
9/29/2014 Documented the extension.
+ 4/12/2016 Added details of OS X RGB workaround.
« no previous file with comments | « content/renderer/webgraphicscontext3d_provider_impl.cc ('k') | gpu/command_buffer/common/capabilities.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698